From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Gemini Lasswell <gazally@runbox.com>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes
Date: Wed, 11 Oct 2017 20:02:12 +0000 [thread overview]
Message-ID: <20171011200212.GA7384@ACM> (raw)
In-Reply-To: <jwv60bpx90r.fsf-monnier+emacsdiffs@gnu.org>
Hello, Stefan.
On Mon, Oct 09, 2017 at 00:13:24 -0400, Stefan Monnier wrote:
> > +@defopt edebug-after-instrumentation-functions
> > +An abnormal hook run by Edebug after it instruments a form.
> > +Each function is called with one argument, a form which has
> > +just been instrumented by Edebug.
> This seems a bit awkward.
Why? How is it at all awkward?
> How 'bout something like the 100% untested patch below?
You don't say why you want to make the patch. It looks to me like you
want to replace a normal abnormal hook with a single function. This is
less flexible (unless one jumps through hoops). It is also
incompatible; it will break applications which use the existing
interface.
Why do you want to break these applications? What benefits will the
new single function scheme bring?
I'm against this incompatible change (which I don't fully understand).
> Stefan
[ .... ]
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2017-10-11 20:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20171008231448.29638.520@vcs0.savannah.gnu.org>
[not found] ` <20171008231451.3FBBC20326@vcs0.savannah.gnu.org>
2017-10-09 4:13 ` [Emacs-diffs] master 06e452a 1/3: Allow Edebug's instrumentation to be used for other purposes Stefan Monnier
2017-10-11 15:44 ` Gemini Lasswell
2017-10-11 16:11 ` Stefan Monnier
2017-10-15 18:06 ` Gemini Lasswell
2017-10-16 1:30 ` Stefan Monnier
2017-10-11 20:02 ` Alan Mackenzie [this message]
2017-10-11 20:32 ` Stefan Monnier
2017-10-11 20:36 ` Alan Mackenzie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171011200212.GA7384@ACM \
--to=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=gazally@runbox.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).