From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: Flymake refactored Date: Fri, 6 Oct 2017 17:22:39 -0400 Message-ID: <20171006212239.lp6ooj5tk5sau2rv@logos.localdomain> References: <87h8vmj3tr.fsf@lolita> <1507138648.1972.0@smtp.gmail.com> <874lre2von.fsf@gmail.com> <87mv566yjx.fsf@udel.edu> <87shex276r.fsf@gmail.com> <87efqh2sud.fsf@udel.edu> <20171006151753.tmdunffovz7olhey@logos.localdomain> <87efqgz2hs.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1507324999 32052 195.159.176.226 (6 Oct 2017 21:23:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 21:23:19 +0000 (UTC) User-Agent: NeoMutt/20170912-97-b97206-dirty Cc: emacs-devel@gnu.org, Simen =?iso-8859-1?Q?Heggest=F8yl?= , dgutov@yandex.ru, Steve Purcell , sdl.web@gmail.com, monnier@iro.umontreal.ca To: =?iso-8859-1?Q?Jo=E3o_T=E1vora?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 06 23:23:15 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0a5S-0007VV-5j for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 23:23:14 +0200 Original-Received: from localhost ([::1]:47205 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0a5Z-0007ze-KC for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 17:23:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0a50-0007zV-Rh for emacs-devel@gnu.org; Fri, 06 Oct 2017 17:22:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0a4w-0004YM-DP for emacs-devel@gnu.org; Fri, 06 Oct 2017 17:22:46 -0400 Original-Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:53751) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0a4w-0004YA-5F for emacs-devel@gnu.org; Fri, 06 Oct 2017 17:22:42 -0400 Original-Received: by mail-qk0-x22c.google.com with SMTP id w63so19182082qkd.10 for ; Fri, 06 Oct 2017 14:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=9m7qFDWo9Wfz8Bq8TD13rKsK2agUekoSBJ0a+mFVEIQ=; b=IY1HJR8sfLbmo/IC7LsVewItfXJxURq+H5inCtFx/JL5JnLudxJeyN5m5HWsjj/iN2 jRlH24HZgj7pxHe35KJGe3iYN6ilD/IzTSSqz/1w+0XTrOI8LaEq5HAW7weoke/oM5Ub vDNRh5Qj4Yx79ticqIXPjIw5N4kNe2N+S45r1LR1db2Zf7wZ4QZoDPQYsXL0Ll4QY/Xl Lkpb9uH+Hs1cNMW4ui0jCA67/Lqra1oVOrcbgsqOiPRBh9EBoR3yztSjWEOSfydveYXs FdqrsCTZlNZjrze29EhlJmNvc7we8NyswT3Mo0XocrwUau6RW+HPWoPyhLhQC865mT+1 qKyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=9m7qFDWo9Wfz8Bq8TD13rKsK2agUekoSBJ0a+mFVEIQ=; b=LjO98E7uJENUpQFvvfAH2pUFllP3d2iV6gMhPQf7jAYKCVfi7FeqI5xAeRoccYAhHt 0KZFhllwYSCo0mX8EfdsqSRV1iP9GCK5yIotqUCWuKxQ3gkPoE1YWM3AiomLudTlmqvy CL9TVHPOIWM9Lr82HG8ldyxBxU6O+PL4DnDfdBBqUU99iCPR2MC6LEmsE2dPpHOcpsmO PDdc3JHliiZqHq8FpfU/xxf9MtX91btGjnX8K8tstTJY9e1QplVsBXE1AcJl5EkmfKcp ECOjuV7wqgdpvI8ObHnI2aQ0t5FoOODztQsH+zyY9fpPnOEjEUM/uLkdV1yRD/M0EY+K z2wQ== X-Gm-Message-State: AMCzsaURz+BZQ/2E4SjIny7kAH2DyuPJZZSnW2Gsq80NoKlYG2gSyCEs nzACwvQFsMK97Udx3pBCAZ5hLw== X-Google-Smtp-Source: AOwi7QBUBIs9jl4uLBrDq9XxtWj96PGOcxahvbQ/F6b4x6OFmr8B8cZX0Qw4NdSvaBQhLc1jvWI2LA== X-Received: by 10.55.185.194 with SMTP id j185mr269666qkf.101.1507324961427; Fri, 06 Oct 2017 14:22:41 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id k126sm898733qkc.69.2017.10.06.14.22.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Oct 2017 14:22:40 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87efqgz2hs.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219211 Archived-At: On 06/10/17 at 05:04pm, João Távora wrote: > Mark Oteiza writes: > > > - some way (global variable?) to disable checkers. I for one never want > > checkdoc to run automatically > > Are add/remove-hook enough? > > (add-hook 'emacs-lisp-mode > (lambda () (remove-hook 'flymake-diagnostic-functions > 'elisp-flymake-checkdoc t))) It's enough, but it might be nicer to have a single place to blacklist things: (setq flymake-diagnostic-blacklist '(elisp-flymake-checkdoc ...)) It somewhat begs the question whether checkers should be registered buffer locally or instead put into the global value of flymake-diagnostic-functions and written like (defun gcc-flymake (report-fn &rest _args) (when (or (derived-mode-p 'c-mode) (derived-mode-p 'c++-mode)) (unless (executable-find gcc-program) (error "Cannot find a suitable gcc")) ...)) but perhaps there is a downside to this beyond possibly needlessly doing a lot of derived-mode-p checks while running through the hook. > > - fine control over when checks happen (again a global setting); > > for instance, on-the-fly can be troublesome if checking is expensive. > > flycheck uses a list: '(save idle-change new-line mode-enabled) > > Global or per-checker? If global, you already have some: > > * flymake-start-syntax-check-on-newline > * flymake-no-changes-timeout (set to nil to disable automatic idle-checking) > * flymake-start-syntax-check-on-find-file > > The "on save" behaviour isn't very easy to configure yet. The names > aren't brilliant, they're inherited from old Flymake. Oh ok, thanks. I missed the latter two variables. > > - popup a special buffer with all the error/warning/info listed > > I really like that one too, and it seems easy enough to do, but we > should also think about the the next-error thingy.