* Re: [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros
[not found] ` <20170928115444.536A4203B7@vcs0.savannah.gnu.org>
@ 2017-09-28 12:38 ` Stefan Monnier
2017-09-29 0:46 ` Mark Oteiza
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2017-09-28 12:38 UTC (permalink / raw)
To: emacs-devel; +Cc: Mark Oteiza
> Add indent spec to easy-mmode macros
> Ideally these macros should expand to the proper code instead of
> relegating all the work to a function call.
Not sure why this comment is in the commit message, but FWIW, I tend to
disagree: it's usually preferable to keep the macro part to a minimum
(handling the syntax), and to keep as much as possible in functions.
There's no hard&fast rule, tho.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros
2017-09-28 12:38 ` [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros Stefan Monnier
@ 2017-09-29 0:46 ` Mark Oteiza
2017-09-29 3:20 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Mark Oteiza @ 2017-09-29 0:46 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On 28/09/17 at 08:38am, Stefan Monnier wrote:
> > Ideally these macros should expand to the proper code instead of
> > relegating all the work to a function call.
>
> FWIW, I tend to
> disagree: it's usually preferable to keep the macro part to a minimum
> (handling the syntax), and to keep as much as possible in functions.
I see, thanks. I tend towards macros that expand to efficient code and
eliminate runtime dependencies; however, like all things it's a trade
off, be it code size, macroexpansion speed, etc.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros
2017-09-29 0:46 ` Mark Oteiza
@ 2017-09-29 3:20 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2017-09-29 3:20 UTC (permalink / raw)
To: Mark Oteiza; +Cc: emacs-devel
> I see, thanks. I tend towards macros that expand to efficient code and
> eliminate runtime dependencies; however, like all things it's a trade
> off, be it code size, macroexpansion speed, etc.
Part of the issue for me is to hardcode a particular behavior.
Going through a function makes it much easier to change the behavior
after the file has been compiled.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-29 3:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170928115443.21221.85942@vcs0.savannah.gnu.org>
[not found] ` <20170928115444.536A4203B7@vcs0.savannah.gnu.org>
2017-09-28 12:38 ` [Emacs-diffs] master 551594e: Add indent spec to easy-mmode macros Stefan Monnier
2017-09-29 0:46 ` Mark Oteiza
2017-09-29 3:20 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).