From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: Emacs 26.1 release branch created Date: Fri, 22 Sep 2017 16:13:42 -0400 Message-ID: <20170922201342.lrl5mpcbss2yntae@logos.localdomain> References: <83377mls4d.fsf@gnu.org> <87bmmazt77.fsf@udel.edu> <83zi9ukbj3.fsf@gnu.org> <20170916145112.GA22458@holos.localdomain> <83wp4yk7ve.fsf@gnu.org> <20170922165941.sirfk6qzfvdfw4i2@logos.localdomain> <83zi9mbj2g.fsf@gnu.org> <20170922200503.u6ipjtezrsoth4xx@logos.localdomain> <83wp4qbiis.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1506111395 14574 195.159.176.226 (22 Sep 2017 20:16:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Sep 2017 20:16:35 +0000 (UTC) User-Agent: NeoMutt/20170912-13-728bb5 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 22 22:16:30 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvUNB-0003XU-PB for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 22:16:29 +0200 Original-Received: from localhost ([::1]:60874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvUNI-0000TF-Ty for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 16:16:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33815) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvUKa-0006Mc-BD for emacs-devel@gnu.org; Fri, 22 Sep 2017 16:13:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvUKW-0006Ay-6Y for emacs-devel@gnu.org; Fri, 22 Sep 2017 16:13:48 -0400 Original-Received: from mail-qt0-x230.google.com ([2607:f8b0:400d:c0d::230]:43340) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvUKW-0006Ao-1T for emacs-devel@gnu.org; Fri, 22 Sep 2017 16:13:44 -0400 Original-Received: by mail-qt0-x230.google.com with SMTP id i50so2200745qtf.0 for ; Fri, 22 Sep 2017 13:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=unPvgfyix7KLuHKpO17cgWGutNzemP6vk1fOR5K8JjA=; b=dufzaDLvO394ZeWL0Z1IPoQTTIh8c3YBevP0wHijmQMZuHaX5B/GhABLsuxT+Ks/iu q62xqg+ue/n9Ex4g7aMuGwRb1PVQahz2wGEwIbNGiaslGCgvceXzDBrj1f2Ltt/1j3mL 8GGC2kV9QV5UG2D7UWLbWfLU3hGNkAjpsbuJz5vN/ApeJjKZskopNn0rvpQJU14H7Hrt xILQ3p5ctpDs2ONnj9kO5hNevcbDkaG2Vhl7sI4xxpOENPG/WKxHSKxOU9AR1Hz4y6Q5 WN7UnBzTXsB5nmMSOKytEw5wxqr8BFpngua5xNg5JzIrQ413nMGLm9tWqvgF+D9RvNR7 V7CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=unPvgfyix7KLuHKpO17cgWGutNzemP6vk1fOR5K8JjA=; b=c+Z2qvJtzlCk4uVoZZqAbwtBGCB+E+XwlpZuQHhgUzLvfbmFK0D2Khbs4dj1AibYSd sqo/ZcKFqkB607iSuhipSK4MWtSkjRpmF9ePm+Os42kkEwUrL/pGQ5hLEzegfdvSTMoG 9w9r8z4iZPa7LJ0PSr8nf3L0GSOD64eD5BhTu/jb2zRxMGU7QyepOpQe6s2qFqgKHUGJ OmIVhlOrzNd0Iga2CK5bXZVrMXjFvSuWNyk504omXMiGZPIIvwkWqshG4ko2daSJISrg ABfN7/EYO3MXkGlrAJtcEF5gwrnvwXNBEum/QErJcm4VkDFzfm5xttBIDf0n+waMUvfG Ljhg== X-Gm-Message-State: AHPjjUjEhayE0YCmKxUrp7AMZosNv4foyfb6hcbgDUMNCnnDazr6cnxm G3TL8PkNXUgLQW/0Jr/humvoSvd29CA= X-Google-Smtp-Source: AOwi7QBwMtODgMgh9pwVSn9aM/zBdP5WcQ554OOTky71Q9y1LvavG+zFlQkJxEXtl+lj3Pkz2sU2KA== X-Received: by 10.200.24.117 with SMTP id n50mr564629qtk.6.1506111223479; Fri, 22 Sep 2017 13:13:43 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id v40sm537874qta.9.2017.09.22.13.13.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 22 Sep 2017 13:13:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <83wp4qbiis.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218709 Archived-At: On 22/09/17 at 08:11pm, Eli Zaretskii wrote: > > Date: Fri, 22 Sep 2017 16:05:03 -0400 > > From: Mark Oteiza > > Cc: emacs-devel@gnu.org > > > > > Hmm... I'm probably missing something, because I don't understand the > > > rationale and the intent of your changes. You introduce a static > > > function lcms2_available_p that is not used anywhere else in the file? > > > > Oops, all the instances of replacing #ifdef'd code with > > init_lcms_functions were meant to instead be calling lcms_available_p. > > Hopefully that makes the intent clear. > > Yes, clear. > > > > And you removed lcms2-available-p without which Lisp code cannot know > > > at run time whether lcms2 support is available or not? Where does > > > this lead? > > > > I don't think having it in Lisp is necessary--isn't it essentially the > > same as (featurep 'lcms2)? > > No, not on MS-Windows. An Emacs binary compiled with lcms2 support, > then moved to a system where lcms2 libraries are not installed will > return t from featurep, but the lcms2 functions will signal an error. Ah, ok. Thanks for the correction.