From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: help-fns unsolicited elisp loading (was Re: bug#28048: 26.0.50; behaviour of C-h f semantic-mode) Date: Fri, 22 Sep 2017 00:09:09 -0400 Message-ID: <20170922040909.5vcbffvvyn7hoexr@logos.localdomain> References: <87poc22mjg.fsf@holos> <2mlgmq14t5.fsf@fencepost.gnu.org> <87poc2qdlj.fsf@holos> <87k2291rru.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1506053365 23928 195.159.176.226 (22 Sep 2017 04:09:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 22 Sep 2017 04:09:25 +0000 (UTC) User-Agent: NeoMutt/20170912-13-728bb5 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Sep 22 06:09:19 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dvFHD-0005jU-DZ for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 06:09:19 +0200 Original-Received: from localhost ([::1]:56590 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvFHJ-00009s-4D for ged-emacs-devel@m.gmane.org; Fri, 22 Sep 2017 00:09:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvFHC-00008A-D0 for emacs-devel@gnu.org; Fri, 22 Sep 2017 00:09:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvFH9-0007Go-5m for emacs-devel@gnu.org; Fri, 22 Sep 2017 00:09:18 -0400 Original-Received: from mail-qk0-x231.google.com ([2607:f8b0:400d:c09::231]:57273) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dvFH8-0007Ev-W5 for emacs-devel@gnu.org; Fri, 22 Sep 2017 00:09:15 -0400 Original-Received: by mail-qk0-x231.google.com with SMTP id g128so2805706qke.13 for ; Thu, 21 Sep 2017 21:09:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KDI/59ckkGm7JeVV7iCvCWKMHTJWHTXUzXdG5l33nAU=; b=fGhBmjvL702AKmLK/XzrWeIT0mSqkk6WgUFNGOt47OktvFrqORK+F57yeOLnMJoo+V D/ySlnRz1/Tbm0BuMBaGxsAq2FZ/kYOyfGj8QEbLzVWrksAmw7tPilIDTAcFiu+UP605 G6U/VEx92TQSGy74GomRFIr+4+f1Hhkgfa0IHROKVUmUTLOmlANF5QMFAS3pfBUZZyBK 5QKtKBYG2g+SSm5DHf5zYxST9Cj5MkfabdMKje2fia1V/izVIK4VaVkIGp/9jy1mIA3t DXnlGLHTQO9YGRDuTflUk7LMxNZz1SuzlJOdcgbpYe8Q559b21EqlFBMPsVuv+tycH1R lZrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KDI/59ckkGm7JeVV7iCvCWKMHTJWHTXUzXdG5l33nAU=; b=aurdC+qrHeH6t8muiTXNty60pcevBbDosGc3BXZqmqKjVCIKdZNYfUsFj2O2bEvQQj gSNDP2SokMPomm7Rkk8TlWxDFMiDyQgIg/U+IXzkuZU22EKwk/mTHajaOceGYPKPmesd ucQzQcs74G8Og2ML38aMeZd1mgoVBBjEqCHFjysLE2ZXPX7g36OvmBVUDiP1RK43DLnc vl0cpSZL4JqAXSJY438Qsg5lNdtSBP+57QvJN7BT4WmgKh47r+2GJ5HbjRivULkNBcse rKjkjq/dVtnGi7qCzWa2EOwmYXYcCj0bnZRdDeR4oJ1LEHd37uAOv6GvLlNVSkTA+hdf Na5A== X-Gm-Message-State: AHPjjUhC/ci/JabcvTTjqSWOU3z5FKTGzXWq9eZVOjAjUArxOuVJvrG3 gtMAK3lzpzzbpY5+ae4qTRcmaWbtyjc= X-Google-Smtp-Source: AOwi7QAlGJbtW6wIpqE7+BaZjxkL8Z5ufQ1+OGQhEwntDUu4TbNF/7Uh1DIx1b1ksj8lIO89hMPsow== X-Received: by 10.55.190.5 with SMTP id o5mr6492222qkf.241.1506053351438; Thu, 21 Sep 2017 21:09:11 -0700 (PDT) Original-Received: from logos.localdomain (pool-173-67-36-61.bltmmd.fios.verizon.net. [173.67.36.61]) by smtp.gmail.com with ESMTPSA id k2sm2065295qth.39.2017.09.21.21.09.10 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 21 Sep 2017 21:09:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87k2291rru.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218670 Archived-At: On 12/08/17 at 01:47am, npostavs@users.sourceforge.net wrote: > Mark Oteiza writes: > > > Is there a bug associated with the new C-h f behaviour? > > No, it was introduced on emacs-devel, see [1] and followups. > > [1]: http://lists.gnu.org/archive/html/emacs-devel/2016-05/msg00441.html Now I know why I'd get seemingly random messages about MH-E not being present on my system. https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=fd8084aaf9 Why are we loading (effectively) arbitrary elisp without the user asking for it? Any elisp in Emacs--including installed 3rdp packages--can get loaded when looking for function or variable help. Further, loading elisp can do anything, so a PoC is trivial. Not even considering the security part of it, I'm going to end up with way more stuff loaded, potentially having more crap to sift through in apropos. Please at the very least disable this by default before it goes into a release. For the record, the following init.el shim restores the previous behavior: (with-eval-after-load "help-fns" (defun my-obarray (string pred action) (complete-with-action action obarray string pred)) (fset 'help--symbol-completion-table 'my-obarray))