unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Doc string and operation of color-distance
Date: Fri, 15 Sep 2017 11:15:59 -0400	[thread overview]
Message-ID: <20170915151559.GA14552@holos.localdomain> (raw)
In-Reply-To: <831sn8m66n.fsf@gnu.org>

On 15/09/17 at 04:40pm, Eli Zaretskii wrote:
> > From: Mark Oteiza <mvoteiza@udel.edu>
> > Date: Thu, 14 Sep 2017 15:43:28 -0400
> > Cc: emacs-devel@gnu.org
> >
> > At the very least we should feed metrics the translated RGBs.
>
> Yes.  But it would be nicer if the lcms.c functions accepted colors in
> any form supported by Emacs: a color name, a string RGB spec, or a
> list of RGB values.  I think.
>
> > Beyond that, in order to use (for example) lcms2-cam02-ucs with
> > color-distance, one has to translate RGB to XYZ, so the metric would be
> >
> >   (lambda (a b)
> >     (lcms2-cam02-ucs (color-srgb-to-xyz a) (color-srgb-to-xyz b))
>
> color-srgb-to-xyz accepts 3 arguments, not one.  Also, its doc string
> says the components are floats between 0 and 1.  So this should be
> amended accordingly.

Ah, yes I forget about color.el's calling conventions…

(defun lcms-rgb16->rgb1 (color)
  (mapcar (lambda (x) (/ (lsh x -8) 255.0)) color))

(lambda (a b)
  (lcms-cam02-ucs (apply #'color-srgb-to-xyz (color-rgb16b->rgb1 a))
                  (apply #'color-srgb-to-xyz (color-rgb16b->rgb1 b))))




  reply	other threads:[~2017-09-15 15:15 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-14 18:45 Doc string and operation of color-distance Eli Zaretskii
2017-09-14 19:12 ` Mark Oteiza
2017-09-15 13:30   ` Eli Zaretskii
2017-09-15 16:45     ` Mark Oteiza
2017-09-15 17:24       ` Eli Zaretskii
2017-09-14 19:43 ` Mark Oteiza
2017-09-14 20:23   ` Mark Oteiza
2017-09-15 13:41     ` Eli Zaretskii
2017-09-15 13:40   ` Eli Zaretskii
2017-09-15 15:15     ` Mark Oteiza [this message]
2017-09-15 16:32     ` Mark Oteiza
2017-09-15 17:26       ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170915151559.GA14552@holos.localdomain \
    --to=mvoteiza@udel.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).