From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent. Date: Thu, 13 Jul 2017 18:00:11 +0000 Message-ID: <20170713180011.GA2321@acm> References: <20170712170703.22088.69111@vcs0.savannah.gnu.org> <20170712170705.8D71A22E12@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1499968936 12944 195.159.176.226 (13 Jul 2017 18:02:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 13 Jul 2017 18:02:16 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 13 20:02:12 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dViRH-00036a-Tq for ged-emacs-devel@m.gmane.org; Thu, 13 Jul 2017 20:02:12 +0200 Original-Received: from localhost ([::1]:33354 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dViRN-0002xB-9N for ged-emacs-devel@m.gmane.org; Thu, 13 Jul 2017 14:02:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40993) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dViQi-0002wb-P0 for emacs-devel@gnu.org; Thu, 13 Jul 2017 14:01:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dViQf-0000dD-MH for emacs-devel@gnu.org; Thu, 13 Jul 2017 14:01:36 -0400 Original-Received: from ocolin.muc.de ([193.149.48.4]:41537 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1dViQf-0000Ya-A2 for emacs-devel@gnu.org; Thu, 13 Jul 2017 14:01:33 -0400 Original-Received: (qmail 37588 invoked by uid 3782); 13 Jul 2017 18:01:30 -0000 Original-Received: from acm.muc.de (p548C7289.dip0.t-ipconnect.de [84.140.114.137]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 13 Jul 2017 20:01:29 +0200 Original-Received: (qmail 2350 invoked by uid 1000); 13 Jul 2017 18:00:11 -0000 Content-Disposition: inline In-Reply-To: X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216590 Archived-At: Hello, Stefan. On Wed, Jul 12, 2017 at 14:10:56 -0400, Stefan Monnier wrote: > > +(defmacro c-set-keymap-parent (map parent) > > + (cond > > + ;; XEmacs > > + ((cc-bytecomp-fboundp 'set-keymap-parents) > > + `(set-keymap-parents ,map ,parent)) > > + ;; Emacs > > + ((cc-bytecomp-fboundp 'set-keymap-parent) > > + `(set-keymap-parent ,map ,parent)) > > + ;; incompatible > > + (t (error "CC Mode is incompatible with this version of Emacs")))) > All versions of Emacs I can think of have `set-keymap-parent`, including > Emacs-19 and XEmacs. Why not just always use `set-keymap-parent`? Why not, indeed? I wasn't aware of the existence of `set-keymap-parent' in XEmacs until you pointed it out. The preferred form in XEmacs is in any case `set-keymap-parents', the singular form being in a file called "obsolete.el". Anyway, it doesn't seem to be a big enough point to be worth raising a fuss over. > Stefan -- Alan Mackenzie (Nuremberg, Germany).