* Re: [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent.
[not found] ` <20170712170705.8D71A22E12@vcs0.savannah.gnu.org>
@ 2017-07-12 18:10 ` Stefan Monnier
2017-07-13 18:00 ` Alan Mackenzie
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2017-07-12 18:10 UTC (permalink / raw)
To: emacs-devel; +Cc: Alan Mackenzie
> +(defmacro c-set-keymap-parent (map parent)
> + (cond
> + ;; XEmacs
> + ((cc-bytecomp-fboundp 'set-keymap-parents)
> + `(set-keymap-parents ,map ,parent))
> + ;; Emacs
> + ((cc-bytecomp-fboundp 'set-keymap-parent)
> + `(set-keymap-parent ,map ,parent))
> + ;; incompatible
> + (t (error "CC Mode is incompatible with this version of Emacs"))))
All versions of Emacs I can think of have `set-keymap-parent`, including
Emacs-19 and XEmacs. Why not just always use `set-keymap-parent`?
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent.
2017-07-12 18:10 ` [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent Stefan Monnier
@ 2017-07-13 18:00 ` Alan Mackenzie
0 siblings, 0 replies; 2+ messages in thread
From: Alan Mackenzie @ 2017-07-13 18:00 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
Hello, Stefan.
On Wed, Jul 12, 2017 at 14:10:56 -0400, Stefan Monnier wrote:
> > +(defmacro c-set-keymap-parent (map parent)
> > + (cond
> > + ;; XEmacs
> > + ((cc-bytecomp-fboundp 'set-keymap-parents)
> > + `(set-keymap-parents ,map ,parent))
> > + ;; Emacs
> > + ((cc-bytecomp-fboundp 'set-keymap-parent)
> > + `(set-keymap-parent ,map ,parent))
> > + ;; incompatible
> > + (t (error "CC Mode is incompatible with this version of Emacs"))))
> All versions of Emacs I can think of have `set-keymap-parent`, including
> Emacs-19 and XEmacs. Why not just always use `set-keymap-parent`?
Why not, indeed? I wasn't aware of the existence of `set-keymap-parent'
in XEmacs until you pointed it out. The preferred form in XEmacs is in
any case `set-keymap-parents', the singular form being in a file called
"obsolete.el".
Anyway, it doesn't seem to be a big enough point to be worth raising a
fuss over.
> Stefan
--
Alan Mackenzie (Nuremberg, Germany).
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-13 18:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170712170703.22088.69111@vcs0.savannah.gnu.org>
[not found] ` <20170712170705.8D71A22E12@vcs0.savannah.gnu.org>
2017-07-12 18:10 ` [Emacs-diffs] master 125a8a6: CC Mode: create and use c-set-keymap-parent Stefan Monnier
2017-07-13 18:00 ` Alan Mackenzie
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).