From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Perry E. Metzger" Newsgroups: gmane.emacs.devel Subject: Re: Advice needed on modeline customization hack... Date: Mon, 17 Apr 2017 08:53:26 -0400 Message-ID: <20170417085326.1e3c4b30@jabberwock.cb.piermont.com> References: <20170415212800.5be89037@jabberwock.cb.piermont.com> <20170416094929.51e94c82@jabberwock.cb.piermont.com> <20170416104633.1768bbb6@jabberwock.cb.piermont.com> <20170416120942.36af8967@jabberwock.cb.piermont.com> <20170416180620.3615b4b6@jabberwock.cb.piermont.com> <20170416181607.4ca1971e@jabberwock.cb.piermont.com> <20170416185740.7d848393@jabberwock.cb.piermont.com> <83ziffefpj.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1492433617 4422 195.159.176.226 (17 Apr 2017 12:53:37 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2017 12:53:37 +0000 (UTC) Cc: cpitclaudel@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 17 14:53:31 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d069r-0000zO-D2 for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 14:53:31 +0200 Original-Received: from localhost ([::1]:36493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d069x-0003s5-Cq for ged-emacs-devel@m.gmane.org; Mon, 17 Apr 2017 08:53:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d069p-0003rk-6w for emacs-devel@gnu.org; Mon, 17 Apr 2017 08:53:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d069o-0000tD-3B for emacs-devel@gnu.org; Mon, 17 Apr 2017 08:53:29 -0400 Original-Received: from hacklheber.piermont.com ([2001:470:30:84:e276:63ff:fe62:3400]:53955) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1d069n-0000sW-VH for emacs-devel@gnu.org; Mon, 17 Apr 2017 08:53:28 -0400 Original-Received: from snark.cb.piermont.com (localhost [127.0.0.1]) by hacklheber.piermont.com (Postfix) with ESMTP id 05E73A85; Mon, 17 Apr 2017 08:53:26 -0400 (EDT) Original-Received: from jabberwock.cb.piermont.com (jabberwock.cb.piermont.com [10.160.2.107]) by snark.cb.piermont.com (Postfix) with ESMTP id 616372DE040; Mon, 17 Apr 2017 08:53:26 -0400 (EDT) In-Reply-To: <83ziffefpj.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:470:30:84:e276:63ff:fe62:3400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:214057 Archived-At: On Mon, 17 Apr 2017 09:00:24 +0300 Eli Zaretskii wrote: > Thanks. Allow me a few comments below. Thank you for taking the time! > > Comments solicited. I'm not fond of the name > > "column-number-mode-starts-from-zero" by the way. > > How about column-number-indicator-zero-based instead? That seems superior. I'll make the change. > > +@vindex column-number-mode-starts-from-zero > > + In Column Number mode, the displayed column number begins at > > zero at +the start of a line. If you would prefer for the > > displayed column +number to begin at one, you may set > > +@code{column-number-mode-starts-from-zero} to @code{nil}. > > The first sentence is ambiguous with the current bidirectional > display, because "start of line" is ambiguous. I suggest to use the > wording with which we describe current-column: > > ... the displayed column number counts from 0 at the left margin > of the window. I'll do that. > I also think that using digits 0 and 1 is better than using the > words, but that's my personal preference, so if you feel strongly > about using words, I won't object. I'm used to the usual rule in English classes that one uses the written out words for small numbers, but this is technical documentation and I think I'll change it to the way you prefer. > Also, please leave 2 spaces between sentences, as we use the US > English conventions in our documentation. I didn't realize that translated through to the final texinfo document. I'll change it. > > @item %c > > -The current column number of point. > > +The current column number of point, starting from zero. > > + > > +@item %C > > +The current column number of point, starting from one. > > I think "zero-based" and "one-based" is better. Or maybe include a > more detailed description of how the column is counted. I'll think about this. I may use your formulation. > Please also add a NEWS entry about this new option. Will write one. How does one do a patch for that, given that by the time this is applied it may be in the wrong place? Or should I just include the blurb and whomever does the commit will add it? > > diff --git a/lisp/simple.el b/lisp/simple.el > > index 5f70adedc4..821880b1f3 100644 > > --- a/lisp/simple.el > > +++ b/lisp/simple.el > > @@ -7198,6 +7198,10 @@ column-number-mode > > If called from Lisp, enable the mode if ARG is omitted or nil." > > :global t :group 'mode-line) > > > > +(defvar column-number-mode-starts-from-zero t > > + "When set to true, Column Number mode displays columns > > starting from zero. +Otherwise, displayed column numbers start > > from one.") > > This should be a defcustom, not defvar. Easily fixed. > I think it's best to have > it in xdisp.c, where the feature is implemented, in which case you > should add the necessary stuff to cus-start.el to allow its > customization by Custom. I thought that since the rest of the lisp side was done there (including the minor mode) that it was better to have it in the .el file. Do you have a strong opinion? > What about the required change to mode_line_update_needed? I no longer need that since I now only increment the column number for the routine that generates the modeline string and not for the variable in the window structure. See the patch for details. Perry -- Perry E. Metzger perry@piermont.com