unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Mark Oteiza <mvoteiza@udel.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: kb1vqh@gmail.com, npostavs@gmail.com, emacs-devel@gnu.org
Subject: Re: master cd0a795: Output number of characters added to file (Bug#354)
Date: Fri, 7 Apr 2017 20:16:00 -0400	[thread overview]
Message-ID: <20170408001600.m3oq4ynv3cayrjqx@holos.localdomain> (raw)
In-Reply-To: <837f2wofjy.fsf@gnu.org>

On 07/04/17 at 10:14am, Eli Zaretskii wrote:
> > From: Mark Oteiza <mvoteiza@udel.edu>
> > Date: Thu, 06 Apr 2017 23:30:41 -0400
> > Cc: Jeff Clough <kb1vqh@gmail.com>, Noam Postavsky <npostavs@gmail.com>
> > 
> > >     Output number of characters added to file (Bug#354)
> > >     
> > >     * fileio.c (write_region):
> > >     * epa-file.el (epa-file-write-region):
> > >     * jka-compr.el (jka-compr-write-region):
> > >     * ange-ftp.el (ange-ftp-write-region):
> > >     * tramp-gvfs.el (tramp-gvfs-handle-write-region):
> > >     * tramp-sh.el (tramp-sh-handle-write-region):
> > >     * mm-util.el (mm-append-to-file): Functions now output
> > >     characters written in addition to file name.
> > >     * files.texi: Added documentation to write-region and
> > >     append-to-file describing their output.
> > 
> > This behavior is unnecessarily verbose, at least when just interactively
> > saving buffers.  Haven't tested this otherwise.  If I cared about the
> > number of characters in the buffer I'd look in the mode line or just do
> > C-x =.
> > 
> > I can't say I've ever been surprised as described in the original
> > report.
> 
> Thanks for the comments.  Would making this an optional feature take
> care of your concerns?

Indeed it would, and IMO it should default to disabled.

> P.S. In the future, it might be better to voice such objections while
> the patch is being discussed, to avoid unnecessary reworking and
> possible frustration caused by that.  TIA.

Of course; however, this only grabbed my attention seeing it after
rebuilding.



  parent reply	other threads:[~2017-04-08  0:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170407022529.14820.30445@vcs0.savannah.gnu.org>
     [not found] ` <20170407022531.17D812084C@vcs0.savannah.gnu.org>
2017-04-07  3:30   ` master cd0a795: Output number of characters added to file (Bug#354) Mark Oteiza
2017-04-07  7:14     ` Eli Zaretskii
2017-04-07 22:50       ` Paul Eggert
2017-04-07 23:02         ` Kaushal Modi
2017-04-08  0:13           ` Noam Postavsky
2017-04-08  0:16       ` Mark Oteiza [this message]
2017-04-07 12:06     ` Noam Postavsky
2017-04-08  0:17       ` Mark Oteiza
2017-04-08  7:34         ` Eli Zaretskii
2017-04-08 14:08           ` Mark Oteiza
2017-04-09 20:03       ` Mark Oteiza
2017-04-07 13:42   ` Michael Albinus
2017-04-07 22:27     ` Noam Postavsky
2017-04-07 16:48   ` Glenn Morris
2017-04-07 21:41     ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170408001600.m3oq4ynv3cayrjqx@holos.localdomain \
    --to=mvoteiza@udel.edu \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=kb1vqh@gmail.com \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).