From: Alan Third <alan@idiocy.org>
To: Emacs-Devel devel <emacs-devel@gnu.org>
Subject: SIGIO and the NS port
Date: Fri, 10 Mar 2017 12:41:17 +0000 [thread overview]
Message-ID: <20170310124117.GA74077@breton.holly.idiocy.org> (raw)
I think I’ve just found a simple solution to a whole class of bugs in
the NS port.
We’ve had a number of bug reports where Emacs crashes while doing UI
related things, for example minimizing the frame, and generally we’ve
found the best way to deal with these is by wrapping the relevant bit
in block_input/unblock_input.
Today I discovered that config.h on my machine has two defines related
to SIGIO:
#define INTERRUPT_INPUT 1
#define USABLE_SIGIO 1
The NS port doesn’t use SIGIO to signal for input (I think it polls
using ns_select), and if I comment these two defines out I can remove
block_input/unblock_input from various places with no ill effects.
Does anyone know of any reason not to remove these two defines?
How would I go about doing that? I assume config.h is generated by
./configure, but I don’t know anything about that side of things.
Thanks!
--
Alan Third
next reply other threads:[~2017-03-10 12:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 12:41 Alan Third [this message]
2017-03-10 13:35 ` SIGIO and the NS port Eli Zaretskii
2017-03-13 16:38 ` Alan Third
2017-05-20 23:24 ` Alan Third
2017-05-21 7:46 ` Paul Eggert
2017-05-21 12:11 ` Alan Third
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170310124117.GA74077@breton.holly.idiocy.org \
--to=alan@idiocy.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).