unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Syntax ambiguities in narrowed buffers and multiple major modes: a proposed solution.
Date: Sun, 26 Feb 2017 12:06:57 +0000	[thread overview]
Message-ID: <20170226120656.GA3811@acm> (raw)
In-Reply-To: <jwvwpcdr8vq.fsf-monnier+Inbox@gnu.org>

Hello, Stefan.

On Sat, Feb 25, 2017 at 21:32:49 -0500, Stefan Monnier wrote:
> > I don't really see the distinction between users and code here.

> I think the details are very different: in Elisp code, it's typically
> combined with save-restriction, it's short lived, and performance is
> fairly important.  For C-x n n none of those three aspects apply.

Sorry, I've lost the thread, here.  The original point was that there is
currently an ambiguity in narrowed regions - that sometimes the
code/user wants to treat point-min as a syntactically neutral point,
other times it wants beginning of buffer to be that neutral point.

I think you've moved onto talking about something else, without saying
exactly what that something else is.

> > If we implement for one, it will work for the other, won't it?

> It's quite likely that if we can make it ...

"it" has no referent.  What is "it"?

> .... work for Elisp, we can also make it work satisfactorily for C-x n
> n.  But the other way around is not necessarily true, I think.

> >> [ I like to consider that strings and comments are also a form of
> >> "island", although we're probably better off supporting them in
> >> a special way like we do now.  ]

> > I think that's just confusing the meaning of "island", which I'd like to
> > keep clear and unambiguous.  Something to be decided is how we'd handle
> > an island within a comment or string.

> Suit yourself.  I find it to be a good way to think about it.

In that case, we'd need some other term to mean what I'm calling an
"island", i.e. a region of buffer bounded by island open/close
syntax-table text properties, possibly with its own syntax table, which
is syntactically disjoint from the surrounding buffer pieces.

> I don't see why an island within a comment/string should need any
> special treatment.  Just like an island within an island.

It doesn't need special treatment, but it does need to be dealt with
somehow.  Probably by silently skipping over the island.  A bit like how
comments are usually skipped in scan-lists.  But I think you're right,
it's not a big thing.

> >> >   o - narrow-to-region will be given an optional argument which, if set,
> >> >     directs Emacs to make the new region an island.  Thus, C-u C-x n n
> >> >     would enable a user to narrow to a "comment within a string" and edit
> >> >     it as though it were a comment.

> >> How would this work (especially for uses from Elisp)?
> >> Would it set syntax-table text-properties?

> > Yes, it would.  It would put an island open syntax-table property on the
> > character before START, and and island close on the character after END.
> > This would isolate the region syntactically from its surroudings.

> I don't think that's going to be fast enough, then.  I'm thinking of
> cases where current Elisp code does something like

>     (save-restriction
>       (narrow-to-region ...)
>       (with-syntax-table ...
>         (backward-sexp 1)))

> in order to efficiently jump over a small element (e.g. an SGML tag) and
> may very well want to do this within a loop.

Is there any need in that example for the narrow-to-region call to
create an island[*]?  Or, more precisely, _when_ is there any need to
create an island?  If this did need an island and were within a loop,
surely the code could be rearranged for the loop to be inside the
with-syntax-table form.

[*] I'm envisaging narrow-to-region getting an &optional parameter
make-island, if that's not clear.

> This usage doesn't correspond to an island, really and shouldn't cause
> caches to be flushed.

I don't think that code would normally need an island.  But the caches
(in particular, the syntax-ppss cache) are invalid inside the
with-syntax-table form anyway, and in the general case that has to be
dealt with somehow.

>         Stefan

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2017-02-26 12:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-25 13:53 Syntax ambiguities in narrowed buffers and multiple major modes: a proposed solution Alan Mackenzie
2017-02-25 19:42 ` Stefan Monnier
2017-02-25 21:22   ` Alan Mackenzie
2017-02-26  2:32     ` Stefan Monnier
2017-02-26 12:06       ` Alan Mackenzie [this message]
2017-02-26 12:24         ` Yuri Khan
2017-02-26 16:10           ` Alan Mackenzie
2017-02-26 13:47         ` Stefan Monnier
2017-02-26 16:37           ` Alan Mackenzie
2017-02-27  4:05             ` Stefan Monnier
2017-02-27 19:05               ` Alan Mackenzie
2017-02-27 20:52                 ` Stefan Monnier
2017-02-27 23:22                   ` Stefan Monnier
2017-02-27 23:48                     ` Dmitry Gutov
2017-02-28 18:58                   ` Alan Mackenzie
2017-02-28 19:09                     ` Stefan Monnier
2017-02-28 20:27                       ` Alan Mackenzie
2017-03-02 22:28                         ` Alan Mackenzie
2017-03-03 12:47 ` Filipp Gunbin
2017-03-04 19:41 ` Tom Tromey
2017-03-24 23:41   ` Alan Mackenzie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170226120656.GA3811@acm \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).