From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 1b4442b: Don't expand body inside a let-binding when there are no bindings Date: Fri, 17 Feb 2017 19:10:25 -0500 Message-ID: <20170218001025.GA4715@holos.localdomain> References: <20170216014306.20854.5128@vcs0.savannah.gnu.org> <20170216014308.12DC326007@vcs0.savannah.gnu.org> <878tp58lzt.fsf@holos> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1487376641 26435 195.159.176.226 (18 Feb 2017 00:10:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Feb 2017 00:10:41 +0000 (UTC) User-Agent: Mutt/1.7.2+46 (7c97a8af8718) (2016-11-26) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 18 01:10:37 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cesbh-00068R-Fm for ged-emacs-devel@m.gmane.org; Sat, 18 Feb 2017 01:10:34 +0100 Original-Received: from localhost ([::1]:56552 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cesbl-0001rp-Mh for ged-emacs-devel@m.gmane.org; Fri, 17 Feb 2017 19:10:37 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52911) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cesbf-0001rZ-0p for emacs-devel@gnu.org; Fri, 17 Feb 2017 19:10:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cesbb-00081q-1Q for emacs-devel@gnu.org; Fri, 17 Feb 2017 19:10:30 -0500 Original-Received: from mail-qk0-x22c.google.com ([2607:f8b0:400d:c09::22c]:34987) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cesba-00081W-Sg for emacs-devel@gnu.org; Fri, 17 Feb 2017 19:10:26 -0500 Original-Received: by mail-qk0-x22c.google.com with SMTP id u25so58096268qki.2 for ; Fri, 17 Feb 2017 16:10:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=W3hz6xdP8Ot+QpAaZXwDw/s/QlPfOV2K5OgbcTshVb8=; b=YPloFJmrfAsHpXlEINL6EckWg6Smeqy7/xklwgRBwLQJO5ogwn592B/9sPD6rh9zWn 4rMcfNUnnFFCBwi4rW9yimMsxaaYwg1bK59ycoq8ldpIrZo0ep34I7k0pZFfHhsuotKp +HgKWchhjUKbO7Q3ydz5l/pd7coirfpmHt/2ZgJfhmIE9lvAc5IWwzDhKXGQna1f3qZJ 5N2E/crGU0dHO6pro0vCMS+W1POlVG4ip5cwqYBeucJmirKSV/d8HQoRcBGXhkhoP1b6 InXvZkgnTC5xbwlxxEh4Mu9y6FDohHR0OmlIOkSg03oFpjhpBjp75Ee8YF3QgF7ZNYFw MS7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=W3hz6xdP8Ot+QpAaZXwDw/s/QlPfOV2K5OgbcTshVb8=; b=PrpVQlaBxLfV0faoXiFU5z7eivcwHqdJTZLvWcdsFMkZyebjQAG0DDpA3/LrowJbR0 hw5wD9yNDbsBFfD9Z/NAIdROXLAto0oa9Ml22SZLWivYGrvl1+AbclcNRoLe9OWBKwC1 W9hcY0HtxIiQ23WikanCOOgW4o8XdjibRTkiVQ7lJqz9z3jcKieXTlzCZpJNRCIvZKSp 9+wDGssLEL+UuQwe2pF0erciG+rxMWMEr9vOiMFTOfDg+LFxCQ/yNyO6caYpljzdP/zI 6EbZ2IQOqcX2YW142j58MV9j9W2R64xW4q49eAZCrth10Zm3JdU/udvuQ2adRFZXyJab ZFmA== X-Gm-Message-State: AMke39lZ1joV8BusN6Beh7PF3u1MRnmobGkKmfQBrvPXZsuT/w4NKSvvB26vmpHdZqXcGjBB X-Received: by 10.233.223.129 with SMTP id t123mr9465347qkf.191.1487376626231; Fri, 17 Feb 2017 16:10:26 -0800 (PST) Original-Received: from holos.localdomain (pool-173-67-40-97.bltmmd.fios.verizon.net. [173.67.40.97]) by smtp.gmail.com with ESMTPSA id x13sm7486395qtc.51.2017.02.17.16.10.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Feb 2017 16:10:25 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 5AEDD5FA83; Fri, 17 Feb 2017 19:10:25 -0500 (EST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212441 Archived-At: On 17/02/17 at 07:05pm, Stefan Monnier wrote: > > In the past I noticed that pcase expanded things to (let nil ...), which > > I think is a bit annoying wrt readability, yes; however just recently I > > was poking at elint.el, which complains about such forms with > > > > Empty varlist in let: (let nil ) > > > > so I was more inclined to change it. > > OK, thanks. > > > Between vars possibly being expensive, and--one step beyond that--using an > > uninterned symbol to ameliorate evalling vars twice incurring a cost > > with dynamic binding, I suppose this change was short sighted. > > Sorry, I didn't understand this part of your message. I was pondering not sending the last part because I was suddenly getting really tired. As long as the change is okay I guess it doesn't matter. Woops.