From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Bug #25608 and the comment-cache branch Date: Thu, 2 Feb 2017 20:24:18 +0000 Message-ID: <20170202202418.GA2505@acm> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1486067144 27619 195.159.176.226 (2 Feb 2017 20:25:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 2 Feb 2017 20:25:44 +0000 (UTC) User-Agent: Mutt/1.7.2 (2016-11-26) To: emacs-devel@gnu.org, Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Feb 02 21:25:40 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cZNwp-0006wp-IC for ged-emacs-devel@m.gmane.org; Thu, 02 Feb 2017 21:25:39 +0100 Original-Received: from localhost ([::1]:58855 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZNwu-00039q-UX for ged-emacs-devel@m.gmane.org; Thu, 02 Feb 2017 15:25:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cZNvv-000382-Vs for emacs-devel@gnu.org; Thu, 02 Feb 2017 15:24:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cZNvr-0000nj-Rc for emacs-devel@gnu.org; Thu, 02 Feb 2017 15:24:43 -0500 Original-Received: from ocolin.muc.de ([193.149.48.4]:22654 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cZNvr-0000nQ-HY for emacs-devel@gnu.org; Thu, 02 Feb 2017 15:24:39 -0500 Original-Received: (qmail 72764 invoked by uid 3782); 2 Feb 2017 20:24:36 -0000 Original-Received: from acm.muc.de (p548C71DF.dip0.t-ipconnect.de [84.140.113.223]) by colin.muc.de (tmda-ofmipd) with ESMTP; Thu, 02 Feb 2017 21:24:35 +0100 Original-Received: (qmail 18053 invoked by uid 1000); 2 Feb 2017 20:24:18 -0000 Content-Disposition: inline X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211889 Archived-At: Hello Eli and Emacs. With bug #25608 (.... /*----------------------------------------------------------------------------- (c) Copyright notice containing open parentheses -----------------------------------------------------------------------------*/ /*---------------------------------------------------------------------------*/ ....), the last line spuriously indents c-basic-offset columns rightwards. The cause of this is the open paren at column zero inside the comment. This is just the latest manifestation of this bug (which surely it is) to hit bug-gnu-emacs and bug-cc-mode. There will surely be more to come if we don't fix it. In the comment-cache branch, the above scenario isn't a bug. It analyses and indents correctly in that branch. I think we are all agreed that Emacs should handle correctly formed comments in C. comment-cache does correctly handle comments, and it has been shown to be essentially no slower than master. I would like to merge comment-cache into master, finally fixing this bug once and for all. What do you say, Eli? -- Alan Mackenzie (Nuremberg, Germany).