From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] checking eww download directory Date: Sat, 28 Jan 2017 16:04:56 -0500 Message-ID: <20170128210456.GA16992@holos.localdomain> References: <87wpdgmi84.fsf@udel.edu> <87inp08g2b.fsf@mouse> <20170127194816.GA18966@holos.localdomain> <87lgtv6zm1.fsf@mouse> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1485637538 2018 195.159.176.226 (28 Jan 2017 21:05:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2017 21:05:38 +0000 (UTC) User-Agent: Mutt/1.7.2+27 (e4ad1dc9bfbd) (2016-11-26) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 28 22:05:34 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cXaBR-00074N-V3 for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 22:05:18 +0100 Original-Received: from localhost ([::1]:53147 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXaBV-0007dc-PS for ged-emacs-devel@m.gmane.org; Sat, 28 Jan 2017 16:05:21 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45671) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXaBG-0007Va-AF for emacs-devel@gnu.org; Sat, 28 Jan 2017 16:05:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXaBB-0000J0-GF for emacs-devel@gnu.org; Sat, 28 Jan 2017 16:05:06 -0500 Original-Received: from mail-qt0-x22c.google.com ([2607:f8b0:400d:c0d::22c]:32826) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cXaBB-0000Ic-9d for emacs-devel@gnu.org; Sat, 28 Jan 2017 16:05:01 -0500 Original-Received: by mail-qt0-x22c.google.com with SMTP id v23so175253052qtb.0 for ; Sat, 28 Jan 2017 13:04:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=qJqI2vAvZsPtLvuMdgxNSzAtoZaSmndI850epuF4qb8=; b=NXjnWnr8w/AIq8fgQzVr/t4wOUidbheKHGjgtp8RPxmOPaZeAiKBdj4zPmSxAdwiUf zy3ugyzHo4s5qY2O76UIB26dB4bl+ucrHQUEVGGSbd7l0WwkLGpmzPJIrSsC98p6GFMV x4kXptQrA0mfSQgotNHlFG/I7nIiblHoy+hRkmcb9uP9I4+pDS3KfSZ4KMJBeyByYO7g ECoa2aih9ArBCnc39tGvW5sjICXMAKd6MrYpuM1oEypV7DKi5urzpoSUFyzt5rKJ1Gsn yoYvpTJ8OhamNWA2gqFffZHWAs8jjz76eHKxmjA8AtYoWfDrrh91B0l/UnJQBT3Gck6U XZuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=qJqI2vAvZsPtLvuMdgxNSzAtoZaSmndI850epuF4qb8=; b=S1X2ioXO1tEm1Fep63QCCfkeYjas3ESf3c5j0Ru6C6aU74WLsf1bAMWNNRBm9eOc+U Zh9euZaD8glFfwkNxM/mzpj5i7suwT/gBenAsi0UeaQCMMsCbES13r5gI+zPOnnDUs+a jm/f363yU7JRzDKp3h/DDkIeR0u2aVkRWQ1gZGcBnLVfPECIJQbqSQX/dV/l01Gw6qWj fsqzSlRe4dNrAGHKR3zVFD6/JvlTeTYx+u8S9hv9nLNU577W4D1kCdkT/UResSll9kfZ zj6Rd3w5xt8BRdhNjdmRWlzTBY/rAHqYx1je2UVAbksw/oGL3Kg3TcOVjwyquONCpmUm plXg== X-Gm-Message-State: AIkVDXJ2HkBBN25wWu9mK/7P9nzovjjZ1IMarwzE7Yzt4k2/TE7ehks/P5YLoM8R1Z2ynIjI X-Received: by 10.200.51.100 with SMTP id u33mr14022843qta.110.1485637498513; Sat, 28 Jan 2017 13:04:58 -0800 (PST) Original-Received: from holos.localdomain (pool-173-67-40-97.bltmmd.fios.verizon.net. [173.67.40.97]) by smtp.gmail.com with ESMTPSA id s75sm7539428qka.36.2017.01.28.13.04.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 28 Jan 2017 13:04:57 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id B56006622C; Sat, 28 Jan 2017 16:04:56 -0500 (EST) Content-Disposition: inline In-Reply-To: <87lgtv6zm1.fsf@mouse> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211712 Archived-At: On 28/01/17 at 03:14pm, Lars Ingebrigtsen wrote: > Mark Oteiza writes: > > > I just went off of knowing it's called Downloads in windows, and trying > > to consider plural/nonplural and case insensitivity on Linux. Mine, for > > instance is just lower cased. So... the cl-some is probably overkill. > > I think it's a good idea to try to find the "downloads" directory on the > host system, but I think this should be factored out into its own > function, so that we can use it in similar circumstances elsewhere. Fair, I'll leave it. > Or perhaps there aren't any other directories like that? Hm... well, > "documents", perhaps, and "desktop"... > > >> > + (access-file eww-download-directory "Download failed") > >> > >> Seem OK, except that the error message should say what the error is > >> instead of this. > > > > It does, access-file appends the error: > > > > Download failed: No such file or directory, ~/NOWOAIWJD > > Oh, cool. Perhaps this line from the doc string could be clearer: Yep, useful function. I changed the docstring words to "prepended to"