From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: The current state of the comment-cache branch Date: Sat, 24 Dec 2016 08:30:55 +0000 Message-ID: <20161224083054.GA2212@acm.fritz.box> References: <20161223215056.GA2771@acm.fritz.box> <83fuldzre1.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1482568326 30641 195.159.176.226 (24 Dec 2016 08:32:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Dec 2016 08:32:06 +0000 (UTC) User-Agent: Mutt/1.5.24 (2015-08-30) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 24 09:32:01 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKhkC-00060P-8m for ged-emacs-devel@m.gmane.org; Sat, 24 Dec 2016 09:31:56 +0100 Original-Received: from localhost ([::1]:42678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKhkC-0004w2-3K for ged-emacs-devel@m.gmane.org; Sat, 24 Dec 2016 03:31:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53289) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKhjc-0004vv-Hl for emacs-devel@gnu.org; Sat, 24 Dec 2016 03:31:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKhjX-0006Vy-Kp for emacs-devel@gnu.org; Sat, 24 Dec 2016 03:31:20 -0500 Original-Received: from ocolin.muc.de ([193.149.48.4]:62893 helo=mail.muc.de) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1cKhjX-0006VH-BI for emacs-devel@gnu.org; Sat, 24 Dec 2016 03:31:15 -0500 Original-Received: (qmail 98105 invoked by uid 3782); 24 Dec 2016 08:31:13 -0000 Original-Received: from acm.muc.de (p4FC462C6.dip0.t-ipconnect.de [79.196.98.198]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sat, 24 Dec 2016 09:31:13 +0100 Original-Received: (qmail 2252 invoked by uid 1000); 24 Dec 2016 08:30:55 -0000 Content-Disposition: inline In-Reply-To: <83fuldzre1.fsf@gnu.org> X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-Received-From: 193.149.48.4 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210774 Archived-At: Hello, Eli. On Sat, Dec 24, 2016 at 10:02:30AM +0200, Eli Zaretskii wrote: > > Date: Fri, 23 Dec 2016 21:50:56 +0000 > > From: Alan Mackenzie > > First forward run Backwards Second forward run > > master: 34.100s 36.050s 34.575s > > comment-cache: 30.110s 32.275s 34.990s > > [...] > > I would like the comment-cache code to be merged into master soon. > Given that the speed-up is around 11% - 13%, and only for the first > scan, what are the other advantages/benefits of this code that would > cause us to merge it? The prime advantage is that we would support open parens in column 0 inside comments. Not through some awkward workaround, but through a change in algorithm, by which these open parens simply aren't even an issue any more. The timings I gave were intented to refute in advance any suggestion that the new code might slow Emacs down, the way setting open-paren-in-column-0-is-defun-start to nil does. > Thanks. -- Alan Mackenzie (Nuremberg, Germany).