From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 3f06795: Migrate auth-source to cl-lib Date: Sat, 12 Nov 2016 19:07:47 -0500 Message-ID: <20161113000747.GA18961@holos.localdomain> References: <20161102191026.12915.33007@vcs.savannah.gnu.org> <20161102191027.3BAA0220149@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1478995718 12484 195.159.176.226 (13 Nov 2016 00:08:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 13 Nov 2016 00:08:38 +0000 (UTC) User-Agent: Mutt/1.7.1+26 (d18482f6641e) (2016-10-04) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 13 01:08:34 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c5iLS-0001oX-C9 for ged-emacs-devel@m.gmane.org; Sun, 13 Nov 2016 01:08:26 +0100 Original-Received: from localhost ([::1]:60068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5iLV-0002iW-GT for ged-emacs-devel@m.gmane.org; Sat, 12 Nov 2016 19:08:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c5iKx-0002iQ-29 for emacs-devel@gnu.org; Sat, 12 Nov 2016 19:07:55 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c5iKt-0007Op-32 for emacs-devel@gnu.org; Sat, 12 Nov 2016 19:07:55 -0500 Original-Received: from mail-qk0-x232.google.com ([2607:f8b0:400d:c09::232]:34481) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c5iKs-0007OQ-S6 for emacs-devel@gnu.org; Sat, 12 Nov 2016 19:07:51 -0500 Original-Received: by mail-qk0-x232.google.com with SMTP id q130so59967113qke.1 for ; Sat, 12 Nov 2016 16:07:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=t1KxHt5lSasS+ppfCa922r1c0mblZh4Jgw/A5choCGw=; b=n9cTuLEaDK73agZqXcq3iglIdOaLBcvshctB+lEpJfpJs0GXoWE8PcplRbNGhq8Y2S e5hxGa0+Mjxq46nfIudPTDsACj9e4G9r4eT3r0VuYPERXxizvE8N+toemEycp3koLh0Z 2FdyYSR0rMl9P6VEj8+Tp8Hl5CTfsg6u2mUFEJek8+twmMNLANG8a40fYvFLv/ZXpD++ MIOntrZbFXxAGJ3DC6zJIbc9aKglCNulv8NeCcbt3akUDXidvNkavTlYMFEDSCjwp2QR HFj4riP20lZuhbB/suum0yc5cfGssYTExBOQQT7hzC+szcM2rorIky3wq6/DaJiqasfV v40Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=t1KxHt5lSasS+ppfCa922r1c0mblZh4Jgw/A5choCGw=; b=LvzohjUa6OmLCM3MlPLjlzL4XZPysg1BJ2/msxaUc9WdF0gTe37qbPuYPPFV6YMiqS Yf0Vnv7QNbWwPhGBrnir45q3WhZFF4nhkjUCBZgSss6UpPmd1yZW7Q8EpcSOan9Tv+Xp 4T7zpDnXzKjuzewjICAsxx6CA5i2wuU79DFhzxyWU56AWw5MBeknhqzmbtcOY98bLGx0 Dp1mr0PgK3PI55wOcJ6VvY6Wxh5ZxlpIioJrHUEtBvokrOU7b84T08aiAYLwAhOPcOoS VyAOXSzo/7mEmqbAJcGc+ldZU17gSodQgaj+XAMfcKo0NAVNevrrraUOjgnZTpXtzNlB afdA== X-Gm-Message-State: ABUngvcpei3DuSlmwTvewhDlzpgq/kOzC1pogV34vXbmNy5+20dnjG1AAt2O56RlKaDS5v1d X-Received: by 10.55.43.158 with SMTP id r30mr9859646qkr.187.1478995669186; Sat, 12 Nov 2016 16:07:49 -0800 (PST) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id w75sm8910910qkb.36.2016.11.12.16.07.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 12 Nov 2016 16:07:48 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 874C5688D2; Sat, 12 Nov 2016 19:07:47 -0500 (EST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209365 Archived-At: On 12/11/16 at 05:57pm, Stefan Monnier wrote: > > @@ -712,7 +712,7 @@ must call it to obtain the actual value." > > (plist-get spec key) > > (slot-value backend key)) > > (setq filtered-backends (delq backend filtered-backends)) > > - (return)) > > + (cl-return)) > > (invalid-slot-name nil)))) > > Hmm... This change looks right, but I believe there's a bug here: > with `cl`, `dolist` is advised to be CL's `dolist` which includes an > implicit (block nil ...) wrapper. But with cl-lib, `dolist` is left alone > and you need to use `cl-dolist` to get that wrapper. > > So I think you need to change the surrounding `dolist` to be `cl-dolist` > otherwise this `cl-return` will exit from the surrounding function > rather than from the inner loop. Argh, I caught one of the dolist/return but missed this one. Thanks, fixed.