* [PATCH] bind n and p in eww bookmark and histories
@ 2016-11-10 1:11 Mark Oteiza
2016-11-10 18:12 ` Lars Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Mark Oteiza @ 2016-11-10 1:11 UTC (permalink / raw)
To: emacs-devel; +Cc: Lars Ingebrigtsen
Hi Lars,
I'd like to add these bindings. Not sure if there is a plan for n and p
to do something else in eww's bookmark or history, judging from the
comments nixed below.
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 7672bf0..1732682 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1736,6 +1736,8 @@ eww-bookmark-mode-map
(define-key map [(control k)] 'eww-bookmark-kill)
(define-key map [(control y)] 'eww-bookmark-yank)
(define-key map "\r" 'eww-bookmark-browse)
+ (define-key map "n" 'next-line)
+ (define-key map "p" 'previous-line)
(easy-menu-define nil map
"Menu for `eww-bookmark-mode-map'."
@@ -1818,8 +1820,8 @@ eww-history-browse
(defvar eww-history-mode-map
(let ((map (make-sparse-keymap)))
(define-key map "\r" 'eww-history-browse)
-;; (define-key map "n" 'next-error-no-select)
-;; (define-key map "p" 'previous-error-no-select)
+ (define-key map "n" 'next-line)
+ (define-key map "p" 'previous-line)
(easy-menu-define nil map
"Menu for `eww-history-mode-map'."
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] bind n and p in eww bookmark and histories
2016-11-10 1:11 [PATCH] bind n and p in eww bookmark and histories Mark Oteiza
@ 2016-11-10 18:12 ` Lars Ingebrigtsen
2016-11-10 18:18 ` Mark Oteiza
0 siblings, 1 reply; 3+ messages in thread
From: Lars Ingebrigtsen @ 2016-11-10 18:12 UTC (permalink / raw)
To: Mark Oteiza; +Cc: emacs-devel
Mark Oteiza <mvoteiza@udel.edu> writes:
> I'd like to add these bindings. Not sure if there is a plan for n and p
> to do something else in eww's bookmark or history, judging from the
> comments nixed below.
>
> diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> index 7672bf0..1732682 100644
> --- a/lisp/net/eww.el
> +++ b/lisp/net/eww.el
> @@ -1736,6 +1736,8 @@ eww-bookmark-mode-map
> (define-key map [(control k)] 'eww-bookmark-kill)
> (define-key map [(control y)] 'eww-bookmark-yank)
> (define-key map "\r" 'eww-bookmark-browse)
> + (define-key map "n" 'next-line)
> + (define-key map "p" 'previous-line)
>
> (easy-menu-define nil map
> "Menu for `eww-bookmark-mode-map'."
> @@ -1818,8 +1820,8 @@ eww-history-browse
> (defvar eww-history-mode-map
> (let ((map (make-sparse-keymap)))
> (define-key map "\r" 'eww-history-browse)
> -;; (define-key map "n" 'next-error-no-select)
> -;; (define-key map "p" 'previous-error-no-select)
> + (define-key map "n" 'next-line)
> + (define-key map "p" 'previous-line)
I'm not sure taking keystrokes we may well want to use later for cursor
movements makes all that much sense. People are perfectly capable to
move the point around without mode-specific bindings, I think. :-)
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bind n and p in eww bookmark and histories
2016-11-10 18:12 ` Lars Ingebrigtsen
@ 2016-11-10 18:18 ` Mark Oteiza
0 siblings, 0 replies; 3+ messages in thread
From: Mark Oteiza @ 2016-11-10 18:18 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: emacs-devel
On 10/11/16 at 07:12pm, Lars Ingebrigtsen wrote:
> Mark Oteiza <mvoteiza@udel.edu> writes:
>
> > I'd like to add these bindings. Not sure if there is a plan for n and p
> > to do something else in eww's bookmark or history, judging from the
> > comments nixed below.
> >
> > diff --git a/lisp/net/eww.el b/lisp/net/eww.el
> > index 7672bf0..1732682 100644
> > --- a/lisp/net/eww.el
> > +++ b/lisp/net/eww.el
> > @@ -1736,6 +1736,8 @@ eww-bookmark-mode-map
> > (define-key map [(control k)] 'eww-bookmark-kill)
> > (define-key map [(control y)] 'eww-bookmark-yank)
> > (define-key map "\r" 'eww-bookmark-browse)
> > + (define-key map "n" 'next-line)
> > + (define-key map "p" 'previous-line)
> >
> > (easy-menu-define nil map
> > "Menu for `eww-bookmark-mode-map'."
> > @@ -1818,8 +1820,8 @@ eww-history-browse
> > (defvar eww-history-mode-map
> > (let ((map (make-sparse-keymap)))
> > (define-key map "\r" 'eww-history-browse)
> > -;; (define-key map "n" 'next-error-no-select)
> > -;; (define-key map "p" 'previous-error-no-select)
> > + (define-key map "n" 'next-line)
> > + (define-key map "p" 'previous-line)
>
> I'm not sure taking keystrokes we may well want to use later for cursor
> movements makes all that much sense. People are perfectly capable to
> move the point around without mode-specific bindings, I think. :-)
It is common for special-modes to have n and p bound to cursor
movements, and those maps have been untouched for a couple years now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-10 18:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 1:11 [PATCH] bind n and p in eww bookmark and histories Mark Oteiza
2016-11-10 18:12 ` Lars Ingebrigtsen
2016-11-10 18:18 ` Mark Oteiza
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).