From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] bind n and p in eww bookmark and histories Date: Thu, 10 Nov 2016 13:18:19 -0500 Message-ID: <20161110181819.GA2503@holos.localdomain> References: <87zil816lq.fsf@udel.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1478804108 9737 195.159.176.226 (10 Nov 2016 18:55:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 10 Nov 2016 18:55:08 +0000 (UTC) User-Agent: Mutt/1.7.1+26 (d18482f6641e) (2016-10-04) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 10 19:54:55 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c4uUk-0007Sm-Hp for ged-emacs-devel@m.gmane.org; Thu, 10 Nov 2016 19:54:42 +0100 Original-Received: from localhost ([::1]:48690 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4uUn-0001x2-Jy for ged-emacs-devel@m.gmane.org; Thu, 10 Nov 2016 13:54:45 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47971) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c4tvc-0004Rp-QX for emacs-devel@gnu.org; Thu, 10 Nov 2016 13:18:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c4tvZ-0001l8-MD for emacs-devel@gnu.org; Thu, 10 Nov 2016 13:18:24 -0500 Original-Received: from mail-qk0-x242.google.com ([2607:f8b0:400d:c09::242]:36670) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c4tvZ-0001kG-Ex for emacs-devel@gnu.org; Thu, 10 Nov 2016 13:18:21 -0500 Original-Received: by mail-qk0-x242.google.com with SMTP id h201so20822785qke.3 for ; Thu, 10 Nov 2016 10:18:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+sq9I3FkaXLMXYgfFQXZpDwHpYR2FYFzIFJCnOs8MbM=; b=IX9j+jLkxJkAIJHam00/7OHNyM4ePvtiynaWrgawnNt3OyyRbisN1R/1fHCqyaF7Gb HZgAWSfLKuzLRQ558kfsYptiTfvwlWS2TrHXWYY8mSFvwmRDEwKodzhXRiyWBo2YTgQx GgnA0nrIba3szDfjnnZv+DJmB1utRXPqh1mdxFqstNmlyCQzO8C9d4hrtkz8NBgT5EAW 92mQ+t4o4FRQeQWFm384LtER+0oEbr4amqaftjPOQE+4/GTfdRVD8tzJVaUf7vMG4LrW 7VtjjEE6RGZx//omgtsA877zX/sx6FkZwNiMmFFtq0lLukV1cjyZE8Ulfqtuny646Vi6 1gvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+sq9I3FkaXLMXYgfFQXZpDwHpYR2FYFzIFJCnOs8MbM=; b=URpq92S6+VcuFx1X5rzpDbWr1E+WgYQTDOLOeJQlDBM7CkWkNd1Z22r/76c8YblhcF Cqz8T/VHDlQSjThqaD7PoAPS6yKjjp6MFBOAp8rJs7TTeur7ntrah9f8AP4CQmPRGx0q tgqzQ/0rRkMJkPFKBtJ6MgwAheTiPyUpMOFsKs3lPmnWFU0feOkO3Dhe2SQCeokHlCDo dEF6mqISD09qzSOOez6HMRL3Hr51h5PYmk1hrFc6jtz0iPsGNp5Wu0b84u2eTwoY//OK HFDBxL1jgQUz82UTOKCHqKYa1eYFFYkpnge55x70eSRA6Sc8eiJNHOwWlsIyzG7pehMK RoLA== X-Gm-Message-State: ABUngvf9NzxyxRHJCuDFh4v3BQBbsH6YNccW0XQldBG7BTnuNC0ooxUQB6MgRQxI/nGQA2Zd X-Received: by 10.55.184.68 with SMTP id i65mr7612673qkf.5.1478801900369; Thu, 10 Nov 2016 10:18:20 -0800 (PST) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id y44sm3145714qtc.45.2016.11.10.10.18.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Nov 2016 10:18:19 -0800 (PST) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 420C7663AA; Thu, 10 Nov 2016 13:18:19 -0500 (EST) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209332 Archived-At: On 10/11/16 at 07:12pm, Lars Ingebrigtsen wrote: > Mark Oteiza writes: > > > I'd like to add these bindings. Not sure if there is a plan for n and p > > to do something else in eww's bookmark or history, judging from the > > comments nixed below. > > > > diff --git a/lisp/net/eww.el b/lisp/net/eww.el > > index 7672bf0..1732682 100644 > > --- a/lisp/net/eww.el > > +++ b/lisp/net/eww.el > > @@ -1736,6 +1736,8 @@ eww-bookmark-mode-map > > (define-key map [(control k)] 'eww-bookmark-kill) > > (define-key map [(control y)] 'eww-bookmark-yank) > > (define-key map "\r" 'eww-bookmark-browse) > > + (define-key map "n" 'next-line) > > + (define-key map "p" 'previous-line) > > > > (easy-menu-define nil map > > "Menu for `eww-bookmark-mode-map'." > > @@ -1818,8 +1820,8 @@ eww-history-browse > > (defvar eww-history-mode-map > > (let ((map (make-sparse-keymap))) > > (define-key map "\r" 'eww-history-browse) > > -;; (define-key map "n" 'next-error-no-select) > > -;; (define-key map "p" 'previous-error-no-select) > > + (define-key map "n" 'next-line) > > + (define-key map "p" 'previous-line) > > I'm not sure taking keystrokes we may well want to use later for cursor > movements makes all that much sense. People are perfectly capable to > move the point around without mode-specific bindings, I think. :-) It is common for special-modes to have n and p bound to cursor movements, and those maps have been untouched for a couple years now.