From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] eww-open-in-new-buffer Date: Wed, 2 Nov 2016 16:52:07 -0400 Message-ID: <20161102205207.GA20062@holos.localdomain> References: <87shramye1.fsf@udel.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1478119977 31482 195.159.176.226 (2 Nov 2016 20:52:57 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 2 Nov 2016 20:52:57 +0000 (UTC) User-Agent: Mutt/1.7+23 (87911ba95dae) (2016-08-17) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 02 21:52:53 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c22W8-0003FY-Sv for ged-emacs-devel@m.gmane.org; Wed, 02 Nov 2016 21:52:16 +0100 Original-Received: from localhost ([::1]:57673 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c22WB-0000FJ-Oz for ged-emacs-devel@m.gmane.org; Wed, 02 Nov 2016 16:52:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32875) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c22W5-0000FB-P5 for emacs-devel@gnu.org; Wed, 02 Nov 2016 16:52:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c22W1-0005Ht-QW for emacs-devel@gnu.org; Wed, 02 Nov 2016 16:52:13 -0400 Original-Received: from mail-qk0-x236.google.com ([2607:f8b0:400d:c09::236]:36809) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c22W1-0005H8-Km for emacs-devel@gnu.org; Wed, 02 Nov 2016 16:52:09 -0400 Original-Received: by mail-qk0-x236.google.com with SMTP id o68so33405785qkf.3 for ; Wed, 02 Nov 2016 13:52:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=t64sXBbG1ZTI4o3AsIDw9npZi39FwZ+19+jGir7OXz0=; b=xnecmmhJlE5IBNPNO87GYXt2wW7IBKPreJTtR0w2j8vAVy6NNtV0K+ljfZLW44K9Jr +e0MgfxUG2EU1zVfNj1I8lUfy2X/dSPwv6ViFSC+M44ujGsu91620MAiUbeYPpSjazc/ 0/iUGP059sWglpYESLug5XFgOCT/mud07RUaX2nmiFAv3pRQqBY4MLrp+OruP0kvwYEU BDR0nsOg8LW1tGMC3r1a1b+qzceYMAREqAhQBVxT1LzkZoaVD34SCXUXOhjGYlninGAT Jf0te3tWULdaOd67R42TVvAsc1thNygE0rRAlVoanPz6bNwFt5FEr0dJAJEYNBuE9iJL qryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=t64sXBbG1ZTI4o3AsIDw9npZi39FwZ+19+jGir7OXz0=; b=bLNX+rqkF7EVCWMIMwkyiXfO7TVtEdF8G8RmVrSNrFV83f4KeuFYyMsYtcw7tpzNJx KHXrsKHaorrOmxJRqkkaAhj287xqazqi9jBlqS4Chqt3EwPYWjCi9T0yilq+jeUuwQbz yLidcwdIB5u2PHi9G8SFF0nTD+R38ysmmW1r3PZUjXWxqV7XIZ58+998HYNB81aXHnSp 8SeAkHwklhpUzZcmzKPJlx5hNrwNdr2ebCJzv/fHRgWeExqWYrd/bJy2CTvTX+1tq17K Uk6cqld8QuVxaA/8aFrvSjiMcQqdbR1KwOrehKLq3zKK6y5KC/fO+gRxRp4qrxk3zE3y PJOA== X-Gm-Message-State: ABUngvdySV9JH560KwAL4yOKbk6s0UKYEvvbOj7OCpj+/Rc2s9FF05vsrfNWT/5BtIxPXXiz X-Received: by 10.55.42.34 with SMTP id q34mr4668935qkh.283.1478119928738; Wed, 02 Nov 2016 13:52:08 -0700 (PDT) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id r57sm2171590qtr.47.2016.11.02.13.52.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Nov 2016 13:52:08 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 3F378688B9; Wed, 2 Nov 2016 16:52:07 -0400 (EDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209129 Archived-At: On 02/11/16 at 08:22pm, Lars Ingebrigtsen wrote: > Mark Oteiza writes: > > > I wanted something akin to "open in new tab" for eww, so I wrote the > > following. > > > > M-RET seemed a good binding. One thing that bugs me about this is that > > eww-current-url in eww-suggest-uris didn't quite fit: as the new > > function is, it doesn't make sense if url is (eww-current-url). > > > > So, I made changes to eww-suggest-uris. Alternatively, > > eww-open-in-new-buffer could check if url is equal to eww-current-url > > and just clone instead of invoking eww. That might be better. > > Looks good to me, I think. It should probably have a NEWS entry and an > eww manual entry, though. > > > (defcustom eww-suggest-uris > > '(eww-links-at-point > > - url-get-url-at-point > > - eww-current-url) > > + url-get-url-at-point) > > And this should have a :version "26.1". Thanks. I ended up implementing the "alternative" since what I had in the patch ended up being weird.