Re: [PATCH] eww-open-in-new-buffer

[Mark Oteiza <mvoteiza@udel.edu>]

On 02/11/16 at 08:22pm, Lars Ingebrigtsen wrote:
> Mark Oteiza <mvoteiza@udel.edu> writes:
> 
> > I wanted something akin to "open in new tab" for eww, so I wrote the
> > following.
> >
> > M-RET seemed a good binding.  One thing that bugs me about this is that
> > eww-current-url in eww-suggest-uris didn't quite fit: as the new
> > function is, it doesn't make sense if url is (eww-current-url).
> >
> > So, I made changes to eww-suggest-uris.  Alternatively,
> > eww-open-in-new-buffer could check if url is equal to eww-current-url
> > and just clone instead of invoking eww.  That might be better.
> 
> Looks good to me, I think.  It should probably have a NEWS entry and an
> eww manual entry, though.
> 
> >  (defcustom eww-suggest-uris
> >    '(eww-links-at-point
> > -    url-get-url-at-point
> > -    eww-current-url)
> > +    url-get-url-at-point)
> 
> And this should have a :version "26.1".

Thanks.  I ended up implementing the "alternative" since what I had in
the patch ended up being weird.