From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lexical-binding mega-patch (was: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el) Date: Wed, 28 Sep 2016 13:17:20 -0400 Message-ID: <20160928171720.GA13522@holos.localdomain> References: <20160810044910.10174.12870@vcs.savannah.gnu.org> <20160810044911.2B1C52201C2@vcs.savannah.gnu.org> <20160811013050.GA4775@holos.localdomain> <20160813181832.GA15753@holos.localdomain> <83mvkgcyh1.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1475083092 4016 195.159.176.226 (28 Sep 2016 17:18:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Sep 2016 17:18:12 +0000 (UTC) User-Agent: Mutt/1.7+23 (87911ba95dae) (2016-08-17) Cc: jwiegley@gmail.com, monnier@iro.umontreal.ca, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 28 19:18:08 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpIUB-0005Gw-Nu for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2016 19:17:35 +0200 Original-Received: from localhost ([::1]:60249 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpIUA-00009s-7T for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2016 13:17:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpIU3-00009Z-Ns for emacs-devel@gnu.org; Wed, 28 Sep 2016 13:17:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpITy-0007UQ-M7 for emacs-devel@gnu.org; Wed, 28 Sep 2016 13:17:26 -0400 Original-Received: from mail-qk0-x241.google.com ([2607:f8b0:400d:c09::241]:33390) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpITy-0007U4-Gj for emacs-devel@gnu.org; Wed, 28 Sep 2016 13:17:22 -0400 Original-Received: by mail-qk0-x241.google.com with SMTP id n66so3106979qkf.0 for ; Wed, 28 Sep 2016 10:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3gon1qTmcQqvwaNfE9bBpG7xD/J/WoFzmSqbPrSIQVM=; b=EgUaMBy3bDac+28rfUNytvZuqZyrM55BpSmesz52xjzYdx+hzyxuuvqVgQonUYo912 1+R6tv7cu5jrc96hd56WzVWnfJlOLznR0ASDm4+DoQPKNoIdTgROQIZmFB4XxmUfoGAb HCCqb+NxEd1AmGWekpqikzd117tQAcz75wniFt1nms2SCT3lSiafQ50Uqc2m5/QkrJaH hOEf1D+pdiGmpChnSF8ehLOpDY7w+rr5ocABhSB/AR4Zy+QPgkjWfZv3X/lpq9GCym2R UasyXSCeAu9VhcUR6oWqpbHro8lmNNM7quw2Z9VebwyRDMBDayhVq2RJlBRtjAZCPzmY 0qNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3gon1qTmcQqvwaNfE9bBpG7xD/J/WoFzmSqbPrSIQVM=; b=kfDa9MKgilKqMPlXyANPbFIT7PUBb/Y40dIRA84QTmVa1bRl3La+OEElBj2DMpbNYv ejKi6ECsAQiorvRH330sYuAzsrv0nHVmzV1ldl6QCL8K3DuZ2HE/mbsJiLS+/Dl6pmdm qVKUMTtsi0bnGEzGjxxx8ASY+CHCeQFef0zwbAShAmiiF7iKS+0fz9nNdS/3Dri9zkb6 5Sy+QuQIi4ic1dQRYRA41E6lBh0YBbbC0zVi78Y8eeruwzPG5Qbu78ty84ohNdcit1bd Uviu3hIiuuwFPXYDpng9TYjDErisPIv1g0xaNNOJTSv5lY8MCcg7fdwFzZN+a+VKAF+2 4TnA== X-Gm-Message-State: AA6/9Rm0CqSg6hKcHQW8mmzlOaXTgs2noEQpJo9LwuzcQD9bGn4SK/k9Aqgz1inoTeRpQvlp X-Received: by 10.55.187.194 with SMTP id l185mr32611922qkf.82.1475083041977; Wed, 28 Sep 2016 10:17:21 -0700 (PDT) Original-Received: from holos.localdomain ([69.250.222.218]) by smtp.gmail.com with ESMTPSA id x21sm4352861qkb.19.2016.09.28.10.17.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Sep 2016 10:17:21 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 56D1A658C5; Wed, 28 Sep 2016 13:17:20 -0400 (EDT) Content-Disposition: inline In-Reply-To: <83mvkgcyh1.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207869 Archived-At: On 13/08/16 at 09:31pm, Eli Zaretskii wrote: > > Date: Sat, 13 Aug 2016 14:18:32 -0400 > > From: Mark Oteiza > > Cc: emacs-devel@gnu.org, John Wiegley , > > Eli Zaretskii > > > > On 10/08/16 at 10:36pm, Stefan Monnier wrote: > > > > Seems like a lot of low hanging fruit to pick and I should post > > > > a patch, WDYT? > > > > > > Go for it. > > > > Done. Flipped the switch and fixed small warnings on files in > > lisp/*.el, but didn't bother with fixing other kinds of warnings or > > altering libs actually using dynamic binding or didn't already have > > a compile-time dependency on cl{,-lib} for {,cl-}pushnew. Nothing > > appears to be broken, but AFAIK I don't make regular use of many of > > these libraries. > > IMO, we should have tests for each one of them before we do this. > > Thanks. Did the above in cbb2e84518 for files that already had tests written. Tests passed.