From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 05dc679: Turn on lexical-binding in json.el Date: Wed, 10 Aug 2016 21:30:50 -0400 Message-ID: <20160811013050.GA4775@holos.localdomain> References: <20160810044910.10174.12870@vcs.savannah.gnu.org> <20160810044911.2B1C52201C2@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: blaine.gmane.org 1470879101 27598 195.159.176.226 (11 Aug 2016 01:31:41 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 11 Aug 2016 01:31:41 +0000 (UTC) User-Agent: Mutt/1.6.2+18 (69bbe4da959f) (2016-07-01) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 11 03:31:37 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bXeqO-00072B-VB for ged-emacs-devel@m.gmane.org; Thu, 11 Aug 2016 03:31:37 +0200 Original-Received: from localhost ([::1]:44982 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXeqL-0005LV-QS for ged-emacs-devel@m.gmane.org; Wed, 10 Aug 2016 21:31:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXepn-0005LO-Ls for emacs-devel@gnu.org; Wed, 10 Aug 2016 21:31:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bXeph-0006W5-Mk for emacs-devel@gnu.org; Wed, 10 Aug 2016 21:30:58 -0400 Original-Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]:33163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bXeph-0006VT-GI for emacs-devel@gnu.org; Wed, 10 Aug 2016 21:30:53 -0400 Original-Received: by mail-qk0-x243.google.com with SMTP id x189so4774830qkd.0 for ; Wed, 10 Aug 2016 18:30:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fg1ieAPFw+iUc8VYm5LXQ/0f1kiAnOT4LU4xTzKDllQ=; b=oiYTya37gWnpPd1bsx9dEq7GrAC6gC0E5Qlc9tPZ2T9nIRt+ekVxjvknThPaixzL5i BIo9bT3MTni/nspqLuI11gw1LcKu9xoa3khJD4Twm0owpsrRN8pFC3N9MwTS1KHXgW2N 5fyeuLnMt2Y/+qIdLulzPa2wxvO3NYe6qwNMfKHM2czrAAHab6xMDUXBqXqezUlrUU5r xj5kQN8dw7ngUpKsmeP90Eb/wz8bDC9u8/g1gH2t9taRPni/YVmjOdyrfj4iAeeFKllZ L8CCJ/iU5LYaQ6WqPBgk46wsRhVd7rK5qMJJuNe10woH0w2OCK8oG4dZwM0HI/yABNe6 9utA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fg1ieAPFw+iUc8VYm5LXQ/0f1kiAnOT4LU4xTzKDllQ=; b=VwJ4+1weV1YqV01BcVQS3NInEBFwdrUW2yTha9QP2RFODVaNgpv4hqR7RvFxyku3Ka Mfd7shy+9On+H8aZAVjS4Ou/+iB1FqgTsHhk6094F5x3+2gR9470J2c1SDDDPAHYwrsC YE0KsGbMpKDnL4m2NrFH+luPYxKBF206xj+TnemY4DMhnWQ8iU4znVOi1tRRD9Wgi7gD R3dfjgLoXWmjVFTwZFxwsc5lB6QIRhy5bVW/z+ROkScagylHW9rUwpn2M8eVI08+gnnT aTOcAFX3cIOnQ57X5aAvjifahMSO3M+e/3dGK7eKsZv8heg/8Dyu6xjElyt0nPtuusjC EoeQ== X-Gm-Message-State: AEkoouv3LcsObNWtuTEPXLpEvXheQNBH5CLSXSvLbBlw0XB+QcflNs0R89MEBvFb10Q7dSCU X-Received: by 10.55.138.134 with SMTP id m128mr4346994qkd.72.1470879052593; Wed, 10 Aug 2016 18:30:52 -0700 (PDT) Original-Received: from holos.localdomain (ip68-100-200-121.dc.dc.cox.net. [68.100.200.121]) by smtp.gmail.com with ESMTPSA id t36sm151349qtd.3.2016.08.10.18.30.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 10 Aug 2016 18:30:51 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id E95C9661B9; Wed, 10 Aug 2016 21:30:50 -0400 (EDT) Content-Disposition: inline In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206556 Archived-At: On 10/08/16 at 11:45am, Stefan Monnier wrote: > > Measuring with (benchmark-run 100 (json-read-file "foobar.json")) > > showed 12-31% reduction in execution time. > > Yay! > > I think it's the first time I see lexical-binding used for performance ;-) json.el can use all the help it can get ;) In any case, I was putzing around and turning on lexical-binding all over the place and found that many files byte-compile happily with lexical-binding enabled, or with minimal changes. Seems like a lot of low hanging fruit to pick and I should post a patch, WDYT? FTR I was going down the list: head -n1 -q lisp/*.el|grep -v 'lexical-binding'