From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [PATCH v3] RFC: eldoc-documentation-functions hook Date: Wed, 20 Jul 2016 19:03:41 -0400 Message-ID: <20160720230341.GA20058@holos.localdomain> References: <20160613211735.GA5969@holos.localdomain> <20160617210849.GA3775@holos.localdomain> <20160707033019.GA22360@holos.localdomain> <87oa5u63hq.fsf@udel.edu> <20160719232017.GA16820@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1469055871 21717 80.91.229.3 (20 Jul 2016 23:04:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Jul 2016 23:04:31 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 21 01:04:25 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bQ0XO-0005ZW-Dj for ged-emacs-devel@m.gmane.org; Thu, 21 Jul 2016 01:04:22 +0200 Original-Received: from localhost ([::1]:37434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ0XN-0005Nw-Al for ged-emacs-devel@m.gmane.org; Wed, 20 Jul 2016 19:04:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ0Wp-0005NQ-8p for emacs-devel@gnu.org; Wed, 20 Jul 2016 19:03:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQ0Wl-0007jb-3u for emacs-devel@gnu.org; Wed, 20 Jul 2016 19:03:46 -0400 Original-Received: from mail-qk0-x22d.google.com ([2607:f8b0:400d:c09::22d]:32830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ0Wk-0007jW-WF for emacs-devel@gnu.org; Wed, 20 Jul 2016 19:03:43 -0400 Original-Received: by mail-qk0-x22d.google.com with SMTP id p74so59399888qka.0 for ; Wed, 20 Jul 2016 16:03:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=mfratpZAGGUkZ1y3mIeEMc0uVuDCB3RbQOaAxfAdNw0=; b=ip4E5qufHcMCorMs4Oy9jKR7zndrIkAV3m6bsLERkZOrP9vCFzLsyubXb77T8x/f0+ RgveJeZ9BUNyChlurqifJYy53Pd44gaDBPzoXbcHtuZb5A91tcZaHgqQmT07pCYNwgMu cKJKUr09nTBl5omj+RE1K44RYmxLd/7ClMXdq1dNv3qxzE1bEjXlfB2JjBCgytKkjEkl 5ks2sKOR6LPICYFuBPW1hmT+4da8i6jlF1ux4pmaIzxlM6XLlR2yRm9TI2Ba/HIyP5FZ Fs4k8eYPwPzu18CzUK2ur5xb3duzWr1ZScoDMnYJ7e1H609/BnTlQsCDiBmhBhxtow10 Z08g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=mfratpZAGGUkZ1y3mIeEMc0uVuDCB3RbQOaAxfAdNw0=; b=lmNx1XTlFBPwTxKeMP7gYjC9F09yDfm+/6FXg3yBbF+SpKl3vOvXgJwNrjDIqXq6lr wWsmEJZnQeAdFjqWMpnAaYPU/artyuyMH2qh1sadayRnD4v3LSn4Wug6rKyCY5IE6HDK DtXmnCzw0RSWPkZ3onZZ7O3PGA2NNOkwxTjOxisVXmiq1HAx8e7iQR2k9CiQkyIehYrJ EsCYZLQ2gOpYoYqS//R71ygNSXxP590tpTC0u4R3kMBIsy09NvpqAjCk6a8NtM9okNBi 1BZvBur6VeW89n1XbPXCuwjfFZ/W3hOODQqbbb0FSW7Y9aHhMs3+JYzizF3OBxyjO25Q 5jVw== X-Gm-Message-State: ALyK8tKTEVLlqsHmAyGbGTrusNg/8Dyo/N01pp7jmnID7Pixlyu8VN/ZfBE2Ye15F+YEEN2L X-Received: by 10.55.33.138 with SMTP id f10mr64178045qki.86.1469055822441; Wed, 20 Jul 2016 16:03:42 -0700 (PDT) Original-Received: from holos.localdomain (ip68-100-200-121.dc.dc.cox.net. [68.100.200.121]) by smtp.gmail.com with ESMTPSA id p2sm2726915qta.15.2016.07.20.16.03.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Jul 2016 16:03:41 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 30E9766C35; Wed, 20 Jul 2016 19:03:41 -0400 (EDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.2+18 (69bbe4da959f) (2016-07-01) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205928 Archived-At: On 19/07/16 at 09:50pm, John Wiegley wrote: > >>>>> Mark Oteiza writes: > > Ok, then perhaps something to the effect of > > (defun run-single-function-hook (hook) > > (let ((global-hook (default-value hook)) > > (local-hook (when (local-variable-p hook) (symbol-value hook)))) > > (or (and (functionp local-hook) (funcall local-hook)) > > (and (functionp global-hook) (funcall global-hook))))) > > > can instead be used. Haven't bothered looking to see if this is useful > > outside of eldoc… > > Is it that the use of nadvice in > cases like these seems heavyweight? Yes. (Though, only now do I realize that what I have written above was written a while ago in Bug#19338)