From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 5811404: Replace eldoc-documentation-function with a hook Date: Thu, 7 Jul 2016 19:59:54 -0400 Message-ID: <20160707235954.GA6381@holos.localdomain> References: <20160707032857.31916.95107@vcs.savannah.gnu.org> <20160707032857.E4A1422015C@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1467936062 2045 80.91.229.3 (8 Jul 2016 00:01:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Jul 2016 00:01:02 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: John Wiegley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 08 02:00:54 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bLJDt-00030K-Ly for ged-emacs-devel@m.gmane.org; Fri, 08 Jul 2016 02:00:50 +0200 Original-Received: from localhost ([::1]:42825 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLJDs-0005yG-FE for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 20:00:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46434) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLJD7-0005xf-KX for emacs-devel@gnu.org; Thu, 07 Jul 2016 20:00:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLJD3-0001gh-MZ for emacs-devel@gnu.org; Thu, 07 Jul 2016 20:00:01 -0400 Original-Received: from mail-qk0-x22a.google.com ([2607:f8b0:400d:c09::22a]:35624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLJD3-0001gd-H1 for emacs-devel@gnu.org; Thu, 07 Jul 2016 19:59:57 -0400 Original-Received: by mail-qk0-x22a.google.com with SMTP id s126so28794500qkh.2 for ; Thu, 07 Jul 2016 16:59:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=FAhRhJK6H7Ir0Qpi4z4lDJoVWCPPNhWNLv9x34yU5g4=; b=Zavqv/ABG/kBgYUsBeywVnuTxbZKTWN/5yCUUp1KNXR4lgHSgb76ac6HUTgq4HIrc5 LWXUlZ0q0c0rrC2VKWX0bRuqgnmy0glDVhg4Pb714B/eXqtX4RBOJpfsESG0yOz+iMJl VXeWmOEYeXs0+mpJy9xRVXwl4TApUZCZiS0zNgs2X8gPWSsgTvj4phrxPTreq7BfA5fj Tonhq8hCAw1mMrGzIHLhK2EPqqZY6GP20/D6nAM+f6AzwyzWIn9ZC430YJfMn+eX/S9a mYgSw0t7+0NwCof6svzBRwwlxohGiiHPwfGI8dAkR6PH2jbATXVREk7e3kDANTFrM5Og bqHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=FAhRhJK6H7Ir0Qpi4z4lDJoVWCPPNhWNLv9x34yU5g4=; b=RUTHfbdT/9Q3OVrHmOqMJ3ip+7hLcF5+cQBdFSYYSYG6gNqn38eKwaAxJpzqcOuRt2 s8somxAk90XfZozalTTMv7gPeBsqWMDBdJgFDQlmoENn4CHHaoeKXP627/vfdzXA/Ivb NI7LBmXmtV5JxXaKA3rP3oWoCGob43irMkUFHvfUQ/TMoF1kJi9OpMjTqlNh3LeZuXdN FELXXBVPahtJf/4SeqfKLW9OibqWTNyqmWH2YRP3gWaQVPdVvVAqt30GyVpoyOKj9RnK nPmoNy65fH0nyz1glDWVLbppKHOUEEms+mxtV1/bxA+e3bCU8h2WsUPoNdJ1oAQmFKqE 8/pg== X-Gm-Message-State: ALyK8tJ3nt0S/788RyfnKXCfiMYGlZus5F4PtoxQHqvWL8Sqpp8tC6C2NBRB39s6ynOTzrua X-Received: by 10.55.179.195 with SMTP id c186mr3964141qkf.28.1467935996816; Thu, 07 Jul 2016 16:59:56 -0700 (PDT) Original-Received: from holos.localdomain (ip68-100-200-121.dc.dc.cox.net. [68.100.200.121]) by smtp.gmail.com with ESMTPSA id t23sm1489263qtc.15.2016.07.07.16.59.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Jul 2016 16:59:55 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id DF633685B5; Thu, 7 Jul 2016 19:59:54 -0400 (EDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.1+68 (bf1c73de2b7c) (2016-04-27) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c09::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205397 Archived-At: On 07/07/16 at 12:31pm, John Wiegley wrote: > >>>>> Stefan Monnier writes: > > > I thought it was agreed that it would be a bad idea. > > I was asked in IRC about this patch, and I couldn't see anything objectionable > about it. However, clearly I was unaware of previous discussion on the matter. > Mark, could you please revert until we have more consensus that we want to do > this? Thank you. Commit fd020a29[0] was implemented only to make it possible for the default value to be used, something hooks already do. See Bug#19338. It is unclear what discussion you are talking about. Perhaps it's here[1], but if not, I hope you will read it before asking me to make more commit noise. One could refer to a number of sources for developer opinion on using advice in core, but perhaps it is best to quote the Elisp manual: […] advice should be reserved for the cases where you cannot modify a function’s behavior in any other way. If it is possible to do the same thing via a hook, that is preferable (see Hooks). […] In particular, Emacs’s own source files should not put advice on functions in Emacs. (There are currently a few exceptions to this convention, but we aim to correct them.) [0] http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=fd020a29 [1] https://lists.gnu.org/archive/html/emacs-devel/2016-06/msg00138.html