From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] RFC: eldoc-documentation-functions hook Date: Mon, 13 Jun 2016 17:17:35 -0400 Message-ID: <20160613211735.GA5969@holos.localdomain> References: <20160612061229.GA6463@holos.localdomain> <838tyahoim.fsf@gnu.org> <20160612182453.GA12034@holos.localdomain> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1465853260 836 80.91.229.3 (13 Jun 2016 21:27:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 13 Jun 2016 21:27:40 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 13 23:27:35 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bCZNZ-0006u6-5G for ged-emacs-devel@m.gmane.org; Mon, 13 Jun 2016 23:26:41 +0200 Original-Received: from localhost ([::1]:59434 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCZNY-0005XX-Cg for ged-emacs-devel@m.gmane.org; Mon, 13 Jun 2016 17:26:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55601) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCZEv-0006J2-4s for emacs-devel@gnu.org; Mon, 13 Jun 2016 17:17:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCZEp-0002b6-J8 for emacs-devel@gnu.org; Mon, 13 Jun 2016 17:17:44 -0400 Original-Received: from mail-qt0-x22b.google.com ([2607:f8b0:400d:c0d::22b]:32914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCZEo-0002an-C1 for emacs-devel@gnu.org; Mon, 13 Jun 2016 17:17:39 -0400 Original-Received: by mail-qt0-x22b.google.com with SMTP id c34so38116422qte.0 for ; Mon, 13 Jun 2016 14:17:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=PyYpgif06RXlNy9XLy2CjLqPEF69CkcqYhUrWgQJqxs=; b=py+1lVqsPtgek3yws5Kg7qPc1vPwbh7N9794+P1/Rvk5ME/+UA9EbZh5vpXF8PAjXK De0RrN8FkZjj4N+YgbSG+10QRT+waaaS7tB082AdEYECpbFXYjYmaraPQWpmVUi4C00H Z+sa6510NmEeUiRN33gnzkcFOQvEpqtLW2T2Rws729lte5CLQqpNrQBJjTosIS7dfNg0 l/A65uZZyIbcJ76s5f2Yhc08oRipupYQkE0AU6RGmeff14djKOOMx84y/dDj82sEpOwq LCx9yHtpsArSXyXgpZnPoboBQrpTYAtgGHwBQEGZSTDRhrOkGW+OrhflyLxB/NmqsXZR szXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=PyYpgif06RXlNy9XLy2CjLqPEF69CkcqYhUrWgQJqxs=; b=I+TXGpYPkxHGBJQRomT2yxAesN63KLR8D3uHx8FkvVpMbt8ywS1QN4rO8+DSrrZQ2I txjTxLnJilNyURofWjHtCWlbx3sZGYVB9Tl3Go/cKY7vzcBRmRTD0ADlPA0RN+Ckf/hn MXQ9UAWF+YdY4wo2OhflrgS+Z2P0BJzqfYnvFPdKeJzKjD1v7lYxcdTNNmAmoi4Osaku ghGSzdiTP4GNyI1SxbGi35Zh8B5MyobCRYPGLUrBXFobIBD2pJt8ArYmq24rHxeDpouF TLESzK4vLzc7F4u5qFiNXa6v8YtQed5okYpR/fLf8dZiEpsc+q9QsRbAk1bhh/LBdFqS RQRg== X-Gm-Message-State: ALyK8tJnVxcaPwD5lDZ4mB4z4SMDNVZQSpSEWmgHug1mZNVMkwnv2f3tD2zkw88ml58MprvH X-Received: by 10.200.53.214 with SMTP id l22mr9420449qtb.62.1465852657670; Mon, 13 Jun 2016 14:17:37 -0700 (PDT) Original-Received: from holos.localdomain (ip68-100-200-121.dc.dc.cox.net. [68.100.200.121]) by smtp.gmail.com with ESMTPSA id i67sm7344007qhi.3.2016.06.13.14.17.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Jun 2016 14:17:36 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 040BD69683; Mon, 13 Jun 2016 17:17:35 -0400 (EDT) Content-Disposition: inline In-Reply-To: <20160612182453.GA12034@holos.localdomain> User-Agent: Mutt/1.6.1+26 (8e342d73159b) (2016-04-27) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c0d::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204346 Archived-At: On 12/06/16 at 02:24pm, Mark Oteiza wrote: > --- > > On 12/06/16 at 10:09am, Eli Zaretskii wrote: > > > Date: Sun, 12 Jun 2016 02:12:29 -0400 > > > From: Mark Oteiza > > > > > > This is a draft patch changing eldoc-documentation-function into a hook > > > variable, so instead of using add-function, one can instead use add-hook > > > to control the behavior of eldoc. It is backwards compatible. > > > > Thanks. Please be sure to update the ELisp manual accordingly. > > changed the default value back to nil, since this isn't being > unconditionally funcall'd anymore. Ah, this was a mistake wrt backwards compatibility. The default can be changed sometime in the future, I suppose. Also had to fix eldoc-supported-p... > In the manual, it appears that the -functions suffix is to be used for > abnormal hooks; however this is a normal hook, so it would seem the name > should use the -hook suffix. ... but I'll wait for some judgement on this before sending another patch.