[PATCH] * lisp/emacs-lisp/seq.el (seq-drop): Use nthcdr for lists.

[PATCH] * lisp/emacs-lisp/seq.el (seq-drop): Use nthcdr for lists.

[Mark Oteiza]

---
 lisp/emacs-lisp/seq.el | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lisp/emacs-lisp/seq.el b/lisp/emacs-lisp/seq.el
index 8362dda..2bb1381 100644
--- a/lisp/emacs-lisp/seq.el
+++ b/lisp/emacs-lisp/seq.el
@@ -449,10 +449,7 @@ seq--elt-safe
 
 (cl-defmethod seq-drop ((list list) n)
   "Optimized implementation of `seq-drop' for lists."
-  (while (and list (> n 0))
-    (setq list (cdr list)
-          n (1- n)))
-  list)
+  (nthcdr n list))
 
 (cl-defmethod seq-take ((list list) n)
   "Optimized implementation of `seq-take' for lists."
-- 
2.8.3

Re: [PATCH] * lisp/emacs-lisp/seq.el (seq-drop): Use nthcdr for lists.

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Mark Oteiza <mvoteiza@udel.edu> writes:

Hi Mark,


>  (cl-defmethod seq-drop ((list list) n)
>    "Optimized implementation of `seq-drop' for lists."
> -  (while (and list (> n 0))
> -    (setq list (cdr list)
> -          n (1- n)))
> -  list)
> +  (nthcdr n list))

Thanks, I applied the patch in both Emacs and ELPA.

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]