From: Alan Mackenzie <acm@muc.de>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Bug #22983 (syntax-ppss returns wrong result) is still open. Could we fix it before the release, please.
Date: Tue, 7 Jun 2016 22:48:29 +0000 [thread overview]
Message-ID: <20160607224829.GC5155@acm.fritz.box> (raw)
In-Reply-To: <7eeaa57a-698d-bde0-d740-efa8968c7583@yandex.ru>
Hello, Dmitry.
On Wed, Jun 08, 2016 at 01:15:47AM +0300, Dmitry Gutov wrote:
> On 06/08/2016 01:09 AM, Alan Mackenzie wrote:
> > I've just tried it again in the emacs-25 branch, and it is as badly
> > broken as it was back in March.
> I think it was considered to be too risky a change even back in March,
> and it was never discussed as a possible blocker.
I think I'd be happy enough about it being fixed in master, if the fix
happens before the release. :-). The trouble is, if there's no
deadline, it'll never get fixed.
> But that's not for me to decide.
> > With this fix, and using this new function in place of the current
> > syntax-ppss in accordance with its spec, the above bug wouldn't happen.
> > If my fix isn't wanted, can somebody who likes syntax-ppss PLEASE fix it
> > before the release, so that, finally, it behaves according to its
> > specification.
> Is there something wrong with the patch I posted?
The one on 2016-03-10 02:49:34 +0200?
Yes, I think having the binary toggle `syntax-ppss-dont-widen' purely to
direct the innards of the function is poor programming (since it
explicitly toggles a toggle inside a supposedly abstract function). I
think an improvement would be to dispense with that toggle, and have two
distinct functions, one in place of `syntax-ppss-dont-widen' being nil,
and the other in place of `s-p-d-w' being non-nil. The latter function
might usefully have an extra parameter specifying the base point that
parse-partial-sexp should be calculated from. That would leave quite a
few options open for the internal logic of the function.
Or something like that.
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=22983#47
Yes, that one. I had trouble finding it on the web archive.
--
Alan Mackenzie (Nuremberg, Germany).
next prev parent reply other threads:[~2016-06-07 22:48 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 22:09 Bug #22983 (syntax-ppss returns wrong result) is still open. Could we fix it before the release, please Alan Mackenzie
2016-06-07 22:15 ` Dmitry Gutov
2016-06-07 22:48 ` Alan Mackenzie [this message]
2016-06-07 23:25 ` Dmitry Gutov
2016-06-11 10:07 ` Alan Mackenzie
2016-06-11 16:10 ` Dmitry Gutov
2016-06-11 19:50 ` Alan Mackenzie
2016-06-11 22:52 ` Dmitry Gutov
2016-06-12 9:34 ` Alan Mackenzie
2016-06-12 22:58 ` Dmitry Gutov
2016-06-13 1:44 ` Clément Pit--Claudel
2016-06-13 12:28 ` Alan Mackenzie
2016-06-13 12:56 ` Stefan Monnier
2016-06-13 13:28 ` Drew Adams
2016-06-13 15:36 ` Dmitry Gutov
2016-06-14 14:55 ` Alan Mackenzie
2016-06-13 21:12 ` John Wiegley
2016-06-13 21:16 ` John Wiegley
2016-06-08 12:43 ` Stefan Monnier
2016-06-11 10:24 ` Alan Mackenzie
2016-06-11 15:00 ` Stefan Monnier
2016-06-11 16:29 ` Dmitry Gutov
2016-06-11 21:24 ` Stefan Monnier
2016-06-11 21:44 ` Alan Mackenzie
2016-06-11 21:49 ` Stefan Monnier
2016-06-11 22:13 ` Alan Mackenzie
2016-06-12 4:06 ` Stefan Monnier
2016-06-11 22:17 ` Dmitry Gutov
2016-06-11 22:21 ` Dmitry Gutov
2016-06-11 16:32 ` Dmitry Gutov
2016-06-11 19:58 ` Alan Mackenzie
2016-06-11 22:28 ` Dmitry Gutov
2016-06-14 9:17 ` Andreas Röhler
2016-06-15 22:11 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607224829.GC5155@acm.fritz.box \
--to=acm@muc.de \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).