* Re: [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face.
[not found] ` <E1arSk2-0005PF-QA@vcs.savannah.gnu.org>
@ 2016-04-26 13:51 ` Stefan Monnier
2016-04-26 15:46 ` Mark Oteiza
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2016-04-26 13:51 UTC (permalink / raw)
To: emacs-devel; +Cc: Mark Oteiza
> Make use of rectangle-preview face.
> * lisp/rect.el (rectangle--string-preview):
> (rectangle--highlight-for-redisplay): Replace 'region with
> 'rectangle-preview (Bug#23248).
I think this patch went a bit overboard: `rectangle-preview' supposedly
refers to the text-preview in C-x r t, whereas the patch also uses
rectangle-preview when you're just selecting a rectangular region.
IOW, I think the part of the patch that touched
rectangle--string-preview was right, but the part that touched
rectangle--highlight-for-redisplay should be reverted.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face.
2016-04-26 13:51 ` [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face Stefan Monnier
@ 2016-04-26 15:46 ` Mark Oteiza
0 siblings, 0 replies; 2+ messages in thread
From: Mark Oteiza @ 2016-04-26 15:46 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
On 26/04/16 at 09:51am, Stefan Monnier wrote:
> > Make use of rectangle-preview face.
>
> > * lisp/rect.el (rectangle--string-preview):
> > (rectangle--highlight-for-redisplay): Replace 'region with
> > 'rectangle-preview (Bug#23248).
>
> I think this patch went a bit overboard: `rectangle-preview' supposedly
> refers to the text-preview in C-x r t, whereas the patch also uses
> rectangle-preview when you're just selecting a rectangular region.
>
> IOW, I think the part of the patch that touched
> rectangle--string-preview was right, but the part that touched
> rectangle--highlight-for-redisplay should be reverted.
Thanks. Fixed in ccb75d72.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-26 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20160416160638.20718.22687@vcs.savannah.gnu.org>
[not found] ` <E1arSk2-0005PF-QA@vcs.savannah.gnu.org>
2016-04-26 13:51 ` [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face Stefan Monnier
2016-04-26 15:46 ` Mark Oteiza
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).