From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Oteiza Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 aa0d83a 1/2: Make use of rectangle-preview face. Date: Tue, 26 Apr 2016 11:46:41 -0400 Message-ID: <20160426154641.GA3871@holos.localdomain> References: <20160416160638.20718.22687@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1461685634 19323 80.91.229.3 (26 Apr 2016 15:47:14 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 26 Apr 2016 15:47:14 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Apr 26 17:47:09 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1av5Cd-0003Xi-5C for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 17:47:07 +0200 Original-Received: from localhost ([::1]:38500 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av5Cc-0005U6-DL for ged-emacs-devel@m.gmane.org; Tue, 26 Apr 2016 11:47:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av5CK-0005Lq-5U for emacs-devel@gnu.org; Tue, 26 Apr 2016 11:46:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av5CG-0004DS-UW for emacs-devel@gnu.org; Tue, 26 Apr 2016 11:46:48 -0400 Original-Received: from mail-qg0-x241.google.com ([2607:f8b0:400d:c04::241]:33646) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av5CG-0004Ci-Lk for emacs-devel@gnu.org; Tue, 26 Apr 2016 11:46:44 -0400 Original-Received: by mail-qg0-x241.google.com with SMTP id 7so1340014qgj.0 for ; Tue, 26 Apr 2016 08:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+2O73goefVs3Kow/gQhMT2ZXePT/nCmQ614hZntqtZ0=; b=geOG6S94EJAmjPm5X8a4SgF0HFGpZh/8LWmLBQyrvsQoRPkAsPJVhSZTUjx/DYv5iw +emw3aq1Jkq+8S3RYHBVvIdfzWfLoZhJEB/GvYpvrha3aOzE5rrQKsda+uw7FAsMhuQh nmXDBbncOOrUXqfzCqTqPNR44H5EUBj83NJ5LtVR0D/rDVg3Lxa3yi8G+8eHBhsWCHTO +I2F09CTOg6p+s+P9JN+tQPdbIdCR8oROpbNJoIYUUmpdSPEZs9IxX5kGqd/o4Psh6fy T2jnCe2jd44rSb8iX1l/+j+f9bkEG8+B1+JAZvOKX7tfgBUvr6haq5VDa5jpHPcLFHnB neKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+2O73goefVs3Kow/gQhMT2ZXePT/nCmQ614hZntqtZ0=; b=bB21DerijbbODss8LaNiIjlomaIWyz/AN616qYvOn7V9nQL1xBxq7CZx5nZmMFgJxk JapLxhV4qsw5iUR2uTziSOiA5RT7CDDjDYdNFEkfs2SzIuLraINHx1zmPLORASf5aSBV mqmfM+ciRt79G8+FLTZIoXrEAcWk4CjeFelLVW8RvvRevrer36FbwxDl2elgjU1H64IK QmIe8/bN9voc4iGMaI36nCjLJr+GXemSeLliXH0AupinzJU1Zk3QK2iPmQNQiQk3zcsC LP53spqaxbiN9SDbgFxlBW7K0esBuqr8+GPU0MWERfOnvAl2wZEK54QU1LHp8wfZr62V 3TBw== X-Gm-Message-State: AOPr4FWvbD4imVEDX86vuQ/gsIQg03fxVA68+LVVe9cnRWi0pN95kf68hz+T/5c/9Jkjw+8d X-Received: by 10.140.28.8 with SMTP id 8mr2861897qgy.91.1461685603606; Tue, 26 Apr 2016 08:46:43 -0700 (PDT) Original-Received: from holos.localdomain (wifi-roaming-128-4-65-40.host.udel.edu. [128.4.65.40]) by smtp.gmail.com with ESMTPSA id 64sm9035189qhf.40.2016.04.26.08.46.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Apr 2016 08:46:42 -0700 (PDT) Original-Received: by holos.localdomain (Postfix, from userid 1000) id 941DA6883A; Tue, 26 Apr 2016 11:46:41 -0400 (EDT) Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24+88 (2a73a6e7c6e7) (2015-08-30) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400d:c04::241 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:203341 Archived-At: On 26/04/16 at 09:51am, Stefan Monnier wrote: > > Make use of rectangle-preview face. > > > * lisp/rect.el (rectangle--string-preview): > > (rectangle--highlight-for-redisplay): Replace 'region with > > 'rectangle-preview (Bug#23248). > > I think this patch went a bit overboard: `rectangle-preview' supposedly > refers to the text-preview in C-x r t, whereas the patch also uses > rectangle-preview when you're just selecting a rectangular region. > > IOW, I think the part of the patch that touched > rectangle--string-preview was right, but the part that touched > rectangle--highlight-for-redisplay should be reverted. Thanks. Fixed in ccb75d72.