unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Alan Schmitt <alan.schmitt@polytechnique.org>
Cc: emacs-devel@gnu.org
Subject: Re: set-text-properties and jit-lock-mode
Date: Sun, 21 Feb 2016 19:04:38 +0000	[thread overview]
Message-ID: <20160221190438.GB2220@acm.fritz.box> (raw)
In-Reply-To: <m24md20wnc.fsf@polytechnique.org>

Hello, Alan.

On Sun, Feb 21, 2016 at 07:02:31PM +0100, Alan Schmitt wrote:
> Hello,

> I'm tracking down a bug in ledger-mode and I'm now at the point where I
> think I need some help about some emacs core code.

> The problem: if jit-lock-mode it t, then using set-text-properties to
> change the face does not work.

> To reproduce: start emacs with -Q. In the scratch buffer, type "foo".
> Then evaluate:
> (set-text-properties 192 195 (list 'face 'italic))

> Nothing changes, and when I do a `describe-char' on one letter of "foo"
> I don't see the face.

At a guess, what's happening here is this: your `set-text-properties'
does indeed work.  But setting text properties is a buffer change.  So
`before-change-functions' and `after-change-functions' will both be
executed.  `a-c-f' contains `jit-lock-after-change', which helpfully
refontifies the line for you.  All this happens before the screen is
redisplayed.

If you bind these hooks to nil around your call, I think it will work:

(let (before-change-functions after-change-functions)
  (set-text-properties 192 195 (list 'face 'italic)))

> If I then evaluate
> (setq jit-lock-mode nil)
> (set-text-properties 192 195 (list 'face 'italic))

> then I see the face change to italic, confirmed by `describe-char'.

> As `set-text-properties' is a function in C, I don't know how to look at
> its source (any pointers on how to do this would be great). Is it
> supposed not to work for faces when jit-lock is on?

> Thanks,

> Alan

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2016-02-21 19:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-21 18:02 set-text-properties and jit-lock-mode Alan Schmitt
2016-02-21 19:04 ` Alan Mackenzie [this message]
2016-02-22  7:29   ` Alan Schmitt
2016-02-24  3:40   ` Stefan Monnier
2016-02-21 20:30 ` Eli Zaretskii
2016-02-22  7:38   ` Alan Schmitt
2016-02-22  8:51     ` Anders Lindgren
2016-02-22  9:02       ` Alan Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160221190438.GB2220@acm.fritz.box \
    --to=acm@muc.de \
    --cc=alan.schmitt@polytechnique.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).