unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Juri Linkov <juri@linkov.net>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] scratch/follow e8937ed: Replace GROUP argument in six window primitives by new functions.
Date: Fri, 18 Dec 2015 10:57:49 +0000	[thread overview]
Message-ID: <20151218105748.GA3191@acm.fritz.box> (raw)
In-Reply-To: <m2lh8sk2n3.fsf_-_@newartisans.com>

Hello, John and Juri.

On Thu, Dec 17, 2015 at 04:43:12PM -0800, John Wiegley wrote:
> >>>>> Juri Linkov <juri@linkov.net> writes:

> >> I think it would have to be `recenter-window-group', but is
> >> `recenter-group' really that ambiguous? People have no problem with
> >> `recenter', which, if anything, is even more ambiguous.

> > I don't know why `recenter' is not `recenter-window' like other existing
> > functions e.g. `reposition-window'. Maybe for historical reasons. But
> > `recenter-group' will add more ambiguity: recenter what? what group?

> I prefer recenter-window-group.

OK, I'm outvoted.  :-)  I've changed the name in the source and
documentation, including changing `recenter-group-function' to
`recenter-window-group-function'.

The end of the week is fast approaching.  I think the time is now ripe
for merging this change into the emacs-25 branch.  Any more objections?

> And maybe we should have `recenter-window' as an alias for `recenter',
> just for consistency.

Or, maybe not.  `recenter' is surely a very old function indeed, and
will have grandfather rights to its name.  I think introducing the alias
(for which there seems no need) would foster confusion.

Also, there is `recenter-top-bottom', which for consistency, would also
want the alias `recenter-window-top-bottom'.

Assuming we have no intention of phasing out the existing names, I don't
think we should introduce the aliases.

> -- 
> John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
> http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

-- 
Alan Mackenzie (Nuremberg, Germany).



  reply	other threads:[~2015-12-18 10:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20151214165252.26784.43201@vcs.savannah.gnu.org>
     [not found] ` <E1a8WMm-0006yi-Di@vcs.savannah.gnu.org>
2015-12-15  1:30   ` [Emacs-diffs] scratch/follow e8937de: Replace GROUP argument in six window primitives by new functions John Wiegley
2015-12-15 13:15     ` Alan Mackenzie
2015-12-15 15:22       ` [Emacs-diffs] scratch/follow e8937ed: " John Wiegley
2015-12-16  0:39       ` [Emacs-diffs] scratch/follow e8937de: " Juri Linkov
2015-12-17 22:14         ` Alan Mackenzie
2015-12-17 23:52           ` Juri Linkov
2015-12-18  0:43             ` [Emacs-diffs] scratch/follow e8937ed: " John Wiegley
2015-12-18 10:57               ` Alan Mackenzie [this message]
2015-12-20 13:05                 ` Alan Mackenzie
2015-12-22 19:19                 ` John Wiegley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151218105748.GA3191@acm.fritz.box \
    --to=acm@muc.de \
    --cc=emacs-devel@gnu.org \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).