From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Sat, 31 Oct 2015 23:56:51 +0000 Message-ID: <20151031235651.GE1853@acm.fritz.box> References: <20140509224458.GA4205@acm.acm> <20151029232302.GB3812@acm.fritz.box> <87h9l6627a.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1446335723 24193 80.91.229.3 (31 Oct 2015 23:55:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Oct 2015 23:55:23 +0000 (UTC) Cc: 17453@debbugs.gnu.org, Stefan Monnier , emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 01 00:55:14 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZsfzO-00085s-2v for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 00:55:14 +0100 Original-Received: from localhost ([::1]:57393 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsfzN-0007s0-8N for ged-emacs-devel@m.gmane.org; Sat, 31 Oct 2015 19:55:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsfzJ-0007pd-Hz for emacs-devel@gnu.org; Sat, 31 Oct 2015 19:55:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZsfzG-0007ji-53 for emacs-devel@gnu.org; Sat, 31 Oct 2015 19:55:09 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:63232) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZsfzF-0007i4-QP for emacs-devel@gnu.org; Sat, 31 Oct 2015 19:55:06 -0400 Original-Received: (qmail 98717 invoked by uid 3782); 31 Oct 2015 23:55:04 -0000 Original-Received: from acm.muc.de (p579E9C22.dip0.t-ipconnect.de [87.158.156.34]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 01 Nov 2015 00:55:03 +0100 Original-Received: (qmail 26527 invoked by uid 1000); 31 Oct 2015 23:56:51 -0000 Content-Disposition: inline In-Reply-To: <87h9l6627a.fsf@mail.linkov.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193043 Archived-At: Hello, Juri. On Sun, Nov 01, 2015 at 01:35:53AM +0200, Juri Linkov wrote: > > If Follow Mode is not enabled, all the above functions do the Right > > Thing on the single window. > >>From another perspective, settings lazy-highlight-buffer to t > (implemented in bug#21092) and removing the current restriction of > (overlay-put ov 'window (selected-window)) will lazy-highlight matches > in all follow windows with no effort. I wasn't actually aware of that fix. There were three main problems my patch fixed: 1) Searching commands were restricted to a single follow window. This was caused by the lazy highlighting mechanism, as you say. 2) Lazy highlighting was only being done in a single window. 3) In scrolling commands, point was restricted to the singled window, rather than being able to move freely throughout all the windows. There were also some subtle things which could go wrong, in particular when the current isearch match spans two windows, and the next command causes the echo area to expand a line. This caused spurious scrolling of the windows. -- Alan Mackenzie (Nuremberg, Germany).