From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Sat, 31 Oct 2015 23:32:25 +0000 Message-ID: <20151031233225.GD1853@acm.fritz.box> References: <20140509224458.GA4205@acm.acm> <20151029232302.GB3812@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1446334260 4655 80.91.229.3 (31 Oct 2015 23:31:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Oct 2015 23:31:00 +0000 (UTC) Cc: 17453@debbugs.gnu.org, Stefan Monnier , emacs-devel To: Artur Malabarba Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 01 00:30:52 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zsfbn-0004vh-Av for ged-emacs-devel@m.gmane.org; Sun, 01 Nov 2015 00:30:51 +0100 Original-Received: from localhost ([::1]:57340 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zsfbm-0003k1-NC for ged-emacs-devel@m.gmane.org; Sat, 31 Oct 2015 19:30:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zsfbj-0003jr-S5 for emacs-devel@gnu.org; Sat, 31 Oct 2015 19:30:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zsfbc-0003U8-Ql for emacs-devel@gnu.org; Sat, 31 Oct 2015 19:30:47 -0400 Original-Received: from mail.muc.de ([193.149.48.3]:46709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zsfbc-0003TX-Di for emacs-devel@gnu.org; Sat, 31 Oct 2015 19:30:40 -0400 Original-Received: (qmail 93852 invoked by uid 3782); 31 Oct 2015 23:30:39 -0000 Original-Received: from acm.muc.de (p579E9C22.dip0.t-ipconnect.de [87.158.156.34]) by colin.muc.de (tmda-ofmipd) with ESMTP; Sun, 01 Nov 2015 00:30:37 +0100 Original-Received: (qmail 26432 invoked by uid 1000); 31 Oct 2015 23:32:25 -0000 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x X-Received-From: 193.149.48.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193040 Archived-At: Hello, Artur On Sat, Oct 31, 2015 at 11:13:34PM +0000, Artur Malabarba wrote: > On 29 Oct 2015 11:23 pm, "Alan Mackenzie" wrote: > > Hello, Stefan, hello, Emacs. > > Resuming a conversation from a year and a half ago, in it I had proposed > > a patch which made isearch work properly in a Follow Mode set of > > windows. In the end, you rejected my patch (in effect), because... > > On Fri, May 09, 2014 at 10:40:07PM -0400, Stefan Monnier wrote: > > > I must say I really dislike this hard-coding of follow-mode support in > > > isearch.el. Isearch should not know so much about follow-mode and > > > follow-mode should not know so much about Isearch either. > > > IOW we should try harder to come up with more general hooks. > What if isearch just took into account all windows displaying > current-buffer, instead of just the selected one? > This wouldn’t involve anything specific to follow mode, and I believe it > would solve the issue, no? I don't think so, really. What exactly does "took into account" mean? With Follow Mode active, on a forward search you explicitly want point to move into the next window when the search target is visible there. When FM is not active, you most definitely don't want this to happen. I have working code which make isearch and FM work together nicely. I think it's a sufficiently "nice" implementation to commit. -- Alan Mackenzie (Nuremberg, Germany).