From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Commit comment rules - and a metaproblem Date: Wed, 3 Dec 2014 15:03:33 -0500 Organization: Eric Conspiracy Secret Labs Message-ID: <20141203200333.GB13738@thyrsus.com> References: <20141203142859.24393.98673@vcs.savannah.gnu.org> <20141203192721.GE12748@thyrsus.com> <547F6774.50700@cs.ucla.edu> Reply-To: esr@thyrsus.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1417637032 3773 80.91.229.3 (3 Dec 2014 20:03:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 3 Dec 2014 20:03:52 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 03 21:03:46 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XwG9J-0002Yw-BC for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 21:03:45 +0100 Original-Received: from localhost ([::1]:43131 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwG9I-0006C4-So for ged-emacs-devel@m.gmane.org; Wed, 03 Dec 2014 15:03:44 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwG9C-0006Bw-GD for emacs-devel@gnu.org; Wed, 03 Dec 2014 15:03:42 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XwG98-0002Fp-8O for emacs-devel@gnu.org; Wed, 03 Dec 2014 15:03:38 -0500 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5]:58570 helo=snark.thyrsus.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XwG98-0002Fj-4n for emacs-devel@gnu.org; Wed, 03 Dec 2014 15:03:34 -0500 Original-Received: by snark.thyrsus.com (Postfix, from userid 1000) id 9D937382EF2; Wed, 3 Dec 2014 15:03:33 -0500 (EST) Content-Disposition: inline In-Reply-To: <547F6774.50700@cs.ucla.edu> X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 71.162.243.5 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:178766 Archived-At: Paul Eggert : > On 12/03/2014 11:27 AM, Eric S. Raymond wrote: > >You want it even when the ChangeLog part is a trivial > >repetition of the summary line? > > It's not needed for one-liners. For commit > e820f16c06a5a6be4bc87910b349c7c3c6eca0f4, for example, your > ChangeLog entry was "* files.el (file-tree-walk): Lisp translation > of ANSI ftw(3).", and that one-liner should have been the git commit > message, too. > > For longer messages, please use the same text for both the ChangeLog > file as for the commit message, except omit the 2nd-blank-line in > the former and omit the leading tabs in the latter. For commit > b1a765b3a8586cd53c21579982c8fbc0ce534336, in contrast, it would have > been better to use the following text (removing indentation) as the > commit message: > > In vc, abolish the dir-status method. > > * vc.el, all backends: API simplification: Abolish dir-status. > It's replaced by dir-status-files. > > and to use the same text (with indentation, but without the blank > line) as the ChangeLog entry. > > It is a pain to have to have essentially two copies of the same > text, one in the ChangeLog file and the other in the commit message, > but we haven't yet had strong consensus on fixing this. A larger problem is that these rules are both fussy and poorly documented - in fact I don't know that they're documented at all. And then there was talk of revoking commit access for violation of fussy and poorly documented rules. Emacs has very few contributors for its size. It desperately needs new blood, but has chronic trouble attracting any. Connect the dots. -- Eric S. Raymond