On Sun, 02 Nov 2014 10:34:28 -0500 Stefan Monnier wrote: > > M-. is bound to a new command `find-definition', which primarily > > calls the value of a new variable `find-definition-function' (by > > default a wrapper around `find-tag' to keep the current > > functionality intact). `find-definition' also keeps track of the > > tag ring, so this would move `find-tag-marker-ring' and related > > functionality out of etags.el, too. > > Yes, this sounds great. > > [...] > > > Comments? > > I'm all for it, Some initial patch attached. Is this what you had in mind when you said the above? Anything I should change to make it fit into Emacs better? I do not know much about Emacs coding conventions. Currently missing: - find-definition does not store locations in the tag ring yet (ran out of time and wanted to post the initial patch for feedback) - The whole "find uses" interface - etags.el integration - emacs-lisp-mode integration This also does define a minor mode instead of changing the global key bindings. I think in the final version it should replace the key binding definitions done in etags.el. Is this correct? Do I need to hook it up elsewhere in the build process? Public git repo for those who find that easier to read / clone (nothing there that isn't in the attached patch): https://github.com/jorgenschaefer/emacs/tree/find-definition https://github.com/jorgenschaefer/emacs/commit/ecac500ac7dee3095863df23c4cd661ba62e2187 Regards, Jorgen