From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Reto Zimmermann Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r116878: Sync with upstream vhdl mode v3.35.1 Date: Fri, 28 Mar 2014 13:50:37 +0100 Message-ID: <20140328135037.Horde.Hkmu2nCKs7FDnFJSl377KA1@webmail.retoweb.net> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed; DelSp=Yes X-Trace: ger.gmane.org 1396011067 30746 80.91.229.3 (28 Mar 2014 12:51:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 28 Mar 2014 12:51:07 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 28 13:51:15 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WTWFf-0003XA-9b for ged-emacs-devel@m.gmane.org; Fri, 28 Mar 2014 13:51:15 +0100 Original-Received: from localhost ([::1]:33452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTWFe-00029d-Nl for ged-emacs-devel@m.gmane.org; Fri, 28 Mar 2014 08:51:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52535) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTWFW-0001xd-8A for emacs-devel@gnu.org; Fri, 28 Mar 2014 08:51:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTWFQ-0008VO-An for emacs-devel@gnu.org; Fri, 28 Mar 2014 08:51:06 -0400 Original-Received: from server09.hostfactory.ch ([212.112.245.152]:50165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTWFQ-0008VG-4H; Fri, 28 Mar 2014 08:51:00 -0400 Original-Received: by server09.hostfactory.ch (Postfix, from userid 10351) id B43DF10E8537; Fri, 28 Mar 2014 13:50:37 +0100 (CET) Original-Received: from 77-57-10-156.dclient.hispeed.ch (77-57-10-156.dclient.hispeed.ch [77.57.10.156]) by webmail.retoweb.net (Horde Framework) with HTTP; Fri, 28 Mar 2014 13:50:37 +0100 In-Reply-To: User-Agent: Internet Messaging Program (IMP) H5 (6.1.6) Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 212.112.245.152 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171072 Archived-At: Quoting Glenn Morris : > Stefan Monnier wrote: > >>> ;; function for expanding abbrevs and dabbrevs >>> -(defalias 'vhdl-expand-abbrev (make-hippie-expand-function >>> - '(try-expand-dabbrev >>> - try-expand-dabbrev-all-buffers >>> - vhdl-try-expand-abbrev))) >>> +(defun vhdl-expand-abbrev (arg)) >>> +(fset 'vhdl-expand-abbrev (make-hippie-expand-function >>> + '(try-expand-dabbrev >>> + try-expand-dabbrev-all-buffers >>> + vhdl-try-expand-abbrev))) >> >> Why??!?! > > Yes, that made no sense to me either. > I meant to think about it before committing, then forgot. > My random guess would be compat with old Emacs versions. > > This is how the code used to be prior to Emacs trunk r108403. > There's no ChangeLog information associated with that commit. > Knowing why it was changed that time would have helped. In 2007 I changed my own copy of vhdl-mode to use defalias. In 2012 I synced some differences from the GNU distribution to my own copy, so it went back to defun/fset (because that's what it was in the repository). I didn't think much about it, so I don't think there was any other reason than just to be in sync with the GNU version. There's other things that are probably still different in my own copy compared to the GNU version, that I did not sync because of compatibility reasons. I meanwhile dropped compatibility with XEmacs, but I still want to prevent any changes that are not compatible with older Emacs versions in the copy that I distribute on my site. Reto