From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jorgen Schaefer Newsgroups: gmane.emacs.devel Subject: Re: Emacs contributions, C and Lisp (was: Re: /srv/bzr/emacs/trunk r101338: ...) Date: Wed, 19 Feb 2014 08:05:24 +0100 Message-ID: <20140219080524.25689b6b@forcix.jorgenschaefer.de> References: <87r47bi1e5.fsf@yandex.ru> <52F96284.50507@yandex.ru> <52FAE12B.6060101@yandex.ru> <52FC3BEE.60604@yandex.ru> <52FCD2B4.5080006@yandex.ru> <52FD9F1D.50205@yandex.ru> <83mwhucg1h.fsf@gnu.org> <878ute589i.fsf@fencepost.gnu.org> <83d2iqc84m.fsf@gnu.org> <87wqgxkcr9.fsf@yandex.ru> <834n41db0d.fsf@gnu.org> <52FE2985.4070703@yandex.ru> <831tz5daes.fsf@gnu.org> <8738jlohd6.fsf@yandex.ru> <83txc1bl83.fsf@gnu.org> <5300189A.9090208@yandex.ru> <83wqgv9fbj.fsf@gnu.org> <20140216180712.236069f6@forcix.jorgenschaefer.de> <83sirj9cyp.fsf@gnu.org> <20140217203145.71a849f7@forcix.jorgenschaefer.de> <837g8t8ouc.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1392793548 28105 80.91.229.3 (19 Feb 2014 07:05:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 19 Feb 2014 07:05:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 19 08:05:54 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WG1E9-0002Hu-C1 for ged-emacs-devel@m.gmane.org; Wed, 19 Feb 2014 08:05:53 +0100 Original-Received: from localhost ([::1]:56765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG1E8-0006oD-NC for ged-emacs-devel@m.gmane.org; Wed, 19 Feb 2014 02:05:52 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG1E2-0006o7-21 for emacs-devel@gnu.org; Wed, 19 Feb 2014 02:05:51 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG1Dw-0003O3-NK for emacs-devel@gnu.org; Wed, 19 Feb 2014 02:05:45 -0500 Original-Received: from loki.jorgenschaefer.de ([87.230.15.51]:34148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG1Dq-0003M8-Gc; Wed, 19 Feb 2014 02:05:34 -0500 Original-Received: by loki.jorgenschaefer.de (Postfix, from userid 998) id 3CD12201392; Wed, 19 Feb 2014 08:05:32 +0100 (CET) Original-Received: from forcix.jorgenschaefer.de (185-23-227-5.lsn.wtnet.de [185.23.227.5]) by loki.jorgenschaefer.de (Postfix) with ESMTPSA id 9E01B201384; Wed, 19 Feb 2014 08:05:25 +0100 (CET) In-Reply-To: <837g8t8ouc.fsf@gnu.org> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.22; i486-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 87.230.15.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169752 Archived-At: On Mon, 17 Feb 2014 22:29:47 +0200 Eli Zaretskii wrote: > > There are a few other minor problems for me. For example, my last > > foray in adding a patch to Emacs was so scary regarding the amount > > of red tape involved in the whole process that I am somewhat > > reluctant to commit to doing that regularly. > > What red tape? Emacs is about the most red-tape-less project as you > can find, as far as the procedure of admitting a patch is considered. If I want to contribute to Emacs, and I want to be good contributor, I have the following things to keep in mind: - Make sure I have done my copyright assignment, and for larger work, do the same for all contributors. - Read etc/CONTRIBUTE and follow all the steps - Which asks me to read the GNU Coding Standards - Oh, and "Tips and Conventions" in the emacs Lisp Reference appendix - Learn a new tool (bzr), for which I have to read http://www.emacswiki.org/emacs/BzrForEmacsDevs (and re-read every time I make a contribution, because bzr is close but suitably different to my usual tools) - Make sure I edit the right ChangeLog in the right format - Remember that the commit message uses the same format as the ChangeLog, and not the usual, lighter, commit message format used by other (git-based) projects - Possibly remember the NEWS entry and the manual update - Remember to add the right "fixes" tag to the bzr commit if I fixed a bug - Have the nagging feeling in the back of my head that if I submit a patch for review, and get told "please install", I have to fight bzr again, or face the real possibility of being berated and attacked publicly on the mailing list, which I have seen happen to at least one other contributor. (Though I should say that the last time I made some contribution mistake, I got a very friendly mail from Stefan asking me to remember the things I forgot next time, a much nicer tone than I am used to from some other projects.) I'd not be surprised if I forgot something. And if I am thinking about contributing a full package, I have to commit to following all of that for the foreseeable future, too. Now, do not get me wrong. I am not complaining about these requirements (so, re-reading the Wikipedia entry on "red tape" I guess the term was badly chosen, sorry, not a native speaker; what's a good term for "*lots* of regulation and rigid conformity to formal rules", as opposed to "*excessive*"?), but I do think it's important to keep in mind that these procedures exist. They do exist for various reasons, usually good ones, but they do reduce the appeal of contributing. Emacs just thinks it's more important to have those procedures than to have more contributors. Which is a perfectly valid decision to make. Regards, Jorgen