From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric S. Raymond" Newsgroups: gmane.emacs.devel Subject: Re: trunk r115926: In preparation for the move to git, sanitize out some Bazaar-specific names. Date: Thu, 9 Jan 2014 07:37:02 -0500 Organization: Eric Conspiracy Secret Labs Message-ID: <20140109123702.GB5361@thyrsus.com> References: <20140109000406.GA22775@thyrsus.com> <87mwj6f23d.fsf@bzg.ath.cx> <20140109002754.GA22950@thyrsus.com> <20140109012554.GA23333@thyrsus.com> <20140109052705.GA3424@thyrsus.com> Reply-To: esr@thyrsus.com NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1389271036 18376 80.91.229.3 (9 Jan 2014 12:37:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jan 2014 12:37:16 +0000 (UTC) Cc: Bastien , Emacs developers To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 09 13:37:24 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W1ErQ-0007vW-NK for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 13:37:20 +0100 Original-Received: from localhost ([::1]:51626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1ErQ-0003Ka-CD for ged-emacs-devel@m.gmane.org; Thu, 09 Jan 2014 07:37:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47287) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1ErJ-0003KJ-EM for emacs-devel@gnu.org; Thu, 09 Jan 2014 07:37:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W1ErE-000668-Ph for emacs-devel@gnu.org; Thu, 09 Jan 2014 07:37:13 -0500 Original-Received: from static-71-162-243-5.phlapa.fios.verizon.net ([71.162.243.5]:37863 helo=snark.thyrsus.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W1Er9-00065f-Ji; Thu, 09 Jan 2014 07:37:03 -0500 Original-Received: by snark.thyrsus.com (Postfix, from userid 1000) id E826D380606; Thu, 9 Jan 2014 07:37:02 -0500 (EST) Content-Disposition: inline In-Reply-To: X-Eric-Conspiracy: There is no conspiracy User-Agent: Mutt/1.5.21 (2010-09-15) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 71.162.243.5 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:167896 Archived-At: Juanma Barranquero : > So, to summarize, I think the right thing to do is: > > 1.- Restore emacs-bzr(-get)-version, with docstring and all. > 2.- (Keep, if you want, your new and currently useless > emacs-revision(-get)-version API) > 3.- Just after the switch, make obsolete the old pair with > > (make-obsolete 'emacs-bzr-get-version 'emacs-repository-get-version "24.4") > (make-obsolete-variable 'emacs-bzr-version 'emacs-repository-version "24.4") I must be missing something. I don't see how this would solve any problem at all. I don't understand why simply looking at emacs-bzr-version isn't working for you, given that it's now aliased. What would (emacs-bug) look at under this plan? If your answer is emacs-bzr-version, I strongly object. The fact that the VCS name was exposed at that level was a *bug*, a layering violation (and I would say the same thing if the name had been emacs-git-version). Nothing in Lisp outside version.el has need to know that and therefore should not know it. You're going to have a flag day either way when the VCS changes; I don't get why pushing it into the future by deferring the rename would help you. I don't see any win at all in this reversion. And because doing it would reintroduce a layering violation, I'm going to need a lot of convincing. -- Eric S. Raymond