From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: John Anthony Newsgroups: gmane.emacs.devel Subject: Hello / First contribution / Major Mode menu entries Date: Wed, 2 Oct 2013 09:27:55 +0400 Message-ID: <20131002052755.GA6413@jo.hnanthony.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1380693253 21947 80.91.229.3 (2 Oct 2013 05:54:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Oct 2013 05:54:13 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 02 07:54:17 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VRFO5-0007hc-3M for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2013 07:54:17 +0200 Original-Received: from localhost ([::1]:34004 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRFO4-0000dA-C9 for ged-emacs-devel@m.gmane.org; Wed, 02 Oct 2013 01:54:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33622) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRFNw-0000ch-C0 for emacs-devel@gnu.org; Wed, 02 Oct 2013 01:54:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VRFNq-00074y-T7 for emacs-devel@gnu.org; Wed, 02 Oct 2013 01:54:08 -0400 Original-Received: from [198.46.132.138] (port=53507 helo=jo.hnanthony.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VRFNq-00074S-OM for emacs-devel@gnu.org; Wed, 02 Oct 2013 01:54:02 -0400 Original-Received: from jo.hnanthony.com (localhost.localdomain [127.0.0.1]) by jo.hnanthony.com (8.14.3/8.14.3/Debian-9.4) with ESMTP id r925RtNt006451 for ; Wed, 2 Oct 2013 09:27:55 +0400 Original-Received: (from john@localhost) by jo.hnanthony.com (8.14.3/8.14.3/Submit) id r925Rt3m006450 for emacs-devel@gnu.org; Wed, 2 Oct 2013 09:27:55 +0400 Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 198.46.132.138 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:163792 Archived-At: Hey there, guys. I'm interested in taking care of a bunch of the little TODO items in etc/TODO. I've read etc/CONTRIBUTE and understand that there are special considerations when contributing to emacs and other FSF projects. I thought I'd start by handling the major mode menu items mentioned on line 65 of etc/TODO. I thought I'd get some feedback before I steam in and do a bunch: diff --git a/lisp/textmodes/text-mode.el b/lisp/textmodes/text-mode.el index d9ff04c..367a84a 100644 --- a/lisp/textmodes/text-mode.el +++ b/lisp/textmodes/text-mode.el @@ -192,4 +192,22 @@ The argument NLINES says how many lines to center." (setq nlines (1+ nlines)) (forward-line -1))))) +(easy-menu-define text-mode-menu text-mode-map + "Menu for Text mode." + '("Text Mode" + ["Center Line" center-line + :help "Center the current line" + :active t] + ["Center Lines" (lambda (n) + (interactive "nNumber of lines to indent: ") + (center-line n)) + :help "Center several lines" + :active t] + ["Center Paragraph" center-paragraph + :help "Center the current paragraph" + :active t] + ["Center Region" center-region + :help "Center the selected region" + :active (region-active-p)])) ;;; text-mode.el ends here When I post such patches to bug-gnu-emacs.org would I be better off submitting a diff generated by bzr? This is my first message to emacs-devel and I'm vaguely aware of the fact that I may not be doing things correctly. I'd very much appreciate any help/advice I could get. Thanks in advance everyone!