* Hello / First contribution / Major Mode menu entries
@ 2013-10-01 20:48 j.anthony
0 siblings, 0 replies; 6+ messages in thread
From: j.anthony @ 2013-10-01 20:48 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1.1: Type: text/plain, Size: 667 bytes --]
Hey there, guys.
I'm interested in taking care of a bunch of the little TODO items in
etc/TODO. I've read etc/CONTRIBUTE and understand that there are
special considerations when contributing to emacs and other FSF
projects. I thought I'd start by handling the major mode menu items
mentioned on line 65 of etc/TODO. I thought I'd get some feedback
before I steam in and do a bunch, so I've attached a diff file of my
first attempt.
This is my first message to emacs-devel and I'm vaguely aware of the
fact that I may not be doing things correctly. I'd very much
appreciate any help/advice I could get.
Thanks in advance everyone and sorry for any silly mistakes!
[-- Attachment #1.2: Type: text/html, Size: 810 bytes --]
[-- Attachment #2: ja-patch-00001.patch --]
[-- Type: application/octet-stream, Size: 916 bytes --]
diff --git a/lisp/textmodes/text-mode.el b/lisp/textmodes/text-mode.el
index d9ff04c..367a84a 100644
--- a/lisp/textmodes/text-mode.el
+++ b/lisp/textmodes/text-mode.el
@@ -192,4 +192,22 @@ The argument NLINES says how many lines to center."
(setq nlines (1+ nlines))
(forward-line -1)))))
+(easy-menu-define text-mode-menu text-mode-map
+ "Menu for Text mode."
+ '("Text Mode"
+ ["Center Line" center-line
+ :help "Center the current line"
+ :active t]
+ ["Center Lines" (lambda (n)
+ (interactive "nNumber of lines to indent: ")
+ (center-line n))
+ :help "Center several lines"
+ :active t]
+ ["Center Paragraph" center-paragraph
+ :help "Center the current paragraph"
+ :active t]
+ ["Center Region" center-region
+ :help "Center the selected region"
+ :active (region-active-p)]))
+
;;; text-mode.el ends here
^ permalink raw reply related [flat|nested] 6+ messages in thread* Hello / First contribution / Major Mode menu entries
@ 2013-10-02 5:27 John Anthony
2013-10-02 14:16 ` Xue Fuqiao
0 siblings, 1 reply; 6+ messages in thread
From: John Anthony @ 2013-10-02 5:27 UTC (permalink / raw)
To: emacs-devel
Hey there, guys.
I'm interested in taking care of a bunch of the little TODO items in
etc/TODO. I've read etc/CONTRIBUTE and understand that there are
special considerations when contributing to emacs and other FSF
projects. I thought I'd start by handling the major mode menu items
mentioned on line 65 of etc/TODO. I thought I'd get some feedback
before I steam in and do a bunch:
diff --git a/lisp/textmodes/text-mode.el b/lisp/textmodes/text-mode.el
index d9ff04c..367a84a 100644
--- a/lisp/textmodes/text-mode.el
+++ b/lisp/textmodes/text-mode.el
@@ -192,4 +192,22 @@ The argument NLINES says how many lines to center."
(setq nlines (1+ nlines))
(forward-line -1)))))
+(easy-menu-define text-mode-menu text-mode-map
+ "Menu for Text mode."
+ '("Text Mode"
+ ["Center Line" center-line
+ :help "Center the current line"
+ :active t]
+ ["Center Lines" (lambda (n)
+ (interactive "nNumber of lines to indent: ")
+ (center-line n))
+ :help "Center several lines"
+ :active t]
+ ["Center Paragraph" center-paragraph
+ :help "Center the current paragraph"
+ :active t]
+ ["Center Region" center-region
+ :help "Center the selected region"
+ :active (region-active-p)]))
;;; text-mode.el ends here
When I post such patches to bug-gnu-emacs.org would I be better off
submitting a diff generated by bzr?
This is my first message to emacs-devel and I'm vaguely aware of the
fact that I may not be doing things correctly. I'd very much
appreciate any help/advice I could get.
Thanks in advance everyone!
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: Hello / First contribution / Major Mode menu entries
2013-10-02 5:27 John Anthony
@ 2013-10-02 14:16 ` Xue Fuqiao
2013-10-03 0:04 ` John Anthony
2013-10-03 3:38 ` Stefan Monnier
0 siblings, 2 replies; 6+ messages in thread
From: Xue Fuqiao @ 2013-10-02 14:16 UTC (permalink / raw)
To: John Anthony; +Cc: emacs-devel
On Wed, Oct 2, 2013 at 1:27 PM, John Anthony <john@jo.hnanthony.com> wrote:
> Hey there, guys.
>
> I'm interested in taking care of a bunch of the little TODO items in
> etc/TODO. I've read etc/CONTRIBUTE and understand that there are
> special considerations when contributing to emacs and other FSF
> projects. I thought I'd start by handling the major mode menu items
> mentioned on line 65 of etc/TODO. I thought I'd get some feedback
> before I steam in and do a bunch:
>
>
> diff --git a/lisp/textmodes/text-mode.el b/lisp/textmodes/text-mode.el
> index d9ff04c..367a84a 100644
> --- a/lisp/textmodes/text-mode.el
> +++ b/lisp/textmodes/text-mode.el
> @@ -192,4 +192,22 @@ The argument NLINES says how many lines to center."
> (setq nlines (1+ nlines))
> (forward-line -1)))))
>
> +(easy-menu-define text-mode-menu text-mode-map
> + "Menu for Text mode."
> + '("Text Mode"
> + ["Center Line" center-line
> + :help "Center the current line"
> + :active t]
> + ["Center Lines" (lambda (n)
> + (interactive "nNumber of lines to indent: ")
> + (center-line n))
> + :help "Center several lines"
> + :active t]
> + ["Center Paragraph" center-paragraph
> + :help "Center the current paragraph"
> + :active t]
> + ["Center Region" center-region
> + :help "Center the selected region"
> + :active (region-active-p)]))
> ;;; text-mode.el ends here
>
>
> When I post such patches to bug-gnu-emacs.org would I be better off
> submitting a diff generated by bzr?
Using ‘diff -c’ to make your diffs is recommended. See (info "(emacs)
Sending Patches").
> This is my first message to emacs-devel and I'm vaguely aware of the
> fact that I may not be doing things correctly. I'd very much
> appreciate any help/advice I could get.
Thanks for wanting to contribute, welcome, and do not hesitate to ask
any further question, we are here to help!
--
Best regards, Xue Fuqiao.
http://www.gnu.org/software/emacs/
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: Hello / First contribution / Major Mode menu entries
2013-10-02 14:16 ` Xue Fuqiao
@ 2013-10-03 0:04 ` John Anthony
2013-10-03 1:03 ` Stephen J. Turnbull
2013-10-03 3:38 ` Stefan Monnier
1 sibling, 1 reply; 6+ messages in thread
From: John Anthony @ 2013-10-03 0:04 UTC (permalink / raw)
To: Xue Fuqiao; +Cc: emacs-devel
On Wed, Oct 02, 2013 at 10:16:22PM +0800, Xue Fuqiao wrote:
> > When I post such patches to bug-gnu-emacs.org would I be better off
> > submitting a diff generated by bzr?
>
> Using ``diff -c'' to make your diffs is recommended. See (info "(emacs)
> Sending Patches").
Thanks for the heads-up. I'll be sure to do this in future.
> > This is my first message to emacs-devel and I'm vaguely aware of the
> > fact that I may not be doing things correctly. I'd very much
> > appreciate any help/advice I could get.
>
> Thanks for wanting to contribute, welcome, and do not hesitate to ask
> any further question, we are here to help!
Thanks for the welcome and not mentioning my double post faux pas. I've
been told to blame the listserv gremlins.
J.A.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Hello / First contribution / Major Mode menu entries
2013-10-03 0:04 ` John Anthony
@ 2013-10-03 1:03 ` Stephen J. Turnbull
0 siblings, 0 replies; 6+ messages in thread
From: Stephen J. Turnbull @ 2013-10-03 1:03 UTC (permalink / raw)
To: John Anthony; +Cc: emacs-devel
John Anthony writes:
> Thanks for the welcome and not mentioning my double post faux pas. I've
> been told to blame the listserv gremlins.
Don't do that, for two reasons. (1) GNU Mailman has no gremlins.
(2) Listserv is a registered trademark of a product not used by GNU,
and you can get sued for libel.
An Unpaid Political Announcement by a proud GNU Mailman developer. I
even have a sticker on my laptop. ;-)
(N.B. IANAL so the second half of (2) is even less reliable than (1),
although the first half of (2) is a verifiable fact.)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Hello / First contribution / Major Mode menu entries
2013-10-02 14:16 ` Xue Fuqiao
2013-10-03 0:04 ` John Anthony
@ 2013-10-03 3:38 ` Stefan Monnier
1 sibling, 0 replies; 6+ messages in thread
From: Stefan Monnier @ 2013-10-03 3:38 UTC (permalink / raw)
To: Xue Fuqiao; +Cc: John Anthony, emacs-devel
> Using ‘diff -c’ to make your diffs is recommended. See (info "(emacs)
> Sending Patches").
Actually, that was Richard's preference. I much prefer "diff -u".
But M-x diff-context->unified or M-x diff-unified->context takes care of
converting from one to the other, so we can adapt.
> When I post such patches to bug-gnu-emacs.org would I be better off
> submitting a diff generated by bzr?
Either way is fine, thank you.
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-10-03 3:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-01 20:48 Hello / First contribution / Major Mode menu entries j.anthony
-- strict thread matches above, loose matches on Subject: below --
2013-10-02 5:27 John Anthony
2013-10-02 14:16 ` Xue Fuqiao
2013-10-03 0:04 ` John Anthony
2013-10-03 1:03 ` Stephen J. Turnbull
2013-10-03 3:38 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).