From: Xue Fuqiao <xfq.free@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: About commit style
Date: Sun, 7 Apr 2013 14:17:06 +0800 [thread overview]
Message-ID: <20130407141706.0ab324342bfb4e0633f03c7c@gmail.com> (raw)
In-Reply-To: <83d2u8dorn.fsf@gnu.org>
On Sat, 06 Apr 2013 11:52:44 +0300
Eli Zaretskii <eliz@gnu.org> wrote:
> The only fixes that can be mixed with other changes are whitespace
> changes, incorrect formatting, etc.
In etc/CONTRIBUTE:
---------------------------------------------------------------------
|** Do not make formatting changes.
|
|Making cosmetic formatting changes (indentation, etc) makes it harder
|to see what you have really changed.
---------------------------------------------------------------------
Can I make changes like this:
* Reindent the file using the default indentation parameters.
* Change some code from putting close-parentheses on lines by themselves
to Lisp style. (Although this almost never happened.)
* Change the comments to satisfy (info "(elisp) Comment Tips").
--
Xue Fuqiao
http://www.gnu.org/software/emacs/
next prev parent reply other threads:[~2013-04-07 6:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-06 8:13 About commit style Xue Fuqiao
2013-04-06 8:52 ` Eli Zaretskii
2013-04-06 9:08 ` Eli Zaretskii
2013-04-06 11:03 ` Xue Fuqiao
2013-04-06 13:10 ` Stefan Monnier
2013-04-06 15:02 ` Eli Zaretskii
2013-04-06 15:32 ` Stefan Monnier
2013-04-06 15:46 ` Andreas Röhler
2013-04-07 6:17 ` Xue Fuqiao [this message]
2013-04-07 15:41 ` Eli Zaretskii
2013-04-07 15:48 ` Stefan Monnier
2013-04-07 22:22 ` Xue Fuqiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130407141706.0ab324342bfb4e0633f03c7c@gmail.com \
--to=xfq.free@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).