From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Xue Fuqiao Newsgroups: gmane.emacs.devel Subject: About commit style Date: Sat, 6 Apr 2013 16:13:08 +0800 Message-ID: <20130406161308.f195518200567a56f123ac05@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1365278523 28287 80.91.229.3 (6 Apr 2013 20:02:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Apr 2013 20:02:03 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 22:02:06 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOZIY-0007UX-Ut for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 22:01:15 +0200 Original-Received: from localhost ([::1]:45450 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOOFK-0003fZ-WD for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 04:13:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:59160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOOFF-0003fJ-D4 for emacs-devel@gnu.org; Sat, 06 Apr 2013 04:13:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOOFC-0003Nn-2L for emacs-devel@gnu.org; Sat, 06 Apr 2013 04:13:05 -0400 Original-Received: from mail-pb0-f43.google.com ([209.85.160.43]:39833) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOOFB-0003Nh-SV for emacs-devel@gnu.org; Sat, 06 Apr 2013 04:13:01 -0400 Original-Received: by mail-pb0-f43.google.com with SMTP id md4so2398536pbc.30 for ; Sat, 06 Apr 2013 01:13:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:subject:message-id:x-mailer:mime-version :content-type:content-transfer-encoding; bh=y742ngsCSQp6cNnNMlLGkP1sdDhuKFZugBoDbifoNLM=; b=xTXO3adJByyJH7wVaqiC0JKxTF0DkSISE4rdMU96MvrFsnxmfioT7SZ621eaEFucz8 iofWVO2e/HkNZTLdXwtMNOCK372BLvgtaH8hFi5KHCrgcDsXVkAFqQkOXx9hmQWe0dZX mbQ7ssu1/MTkmecGrkCtBhoYjt/WhFrmPlOW5xhplzwFhSvKFqCHyhEWYLmx16Xx5g5p Sgl/euLnWpqURLgMJV7/6FWQesw38eolZWfIdKY/R/3pd6PTFYYhCvDZkBeqnXvUY3sF YD7L+8MPD+4JmRjmJSYz/0SjAjoVIcHthDbZ7aqxSeQC54oQUT6QQwlXog1wf5+5BCj/ 5jiQ== X-Received: by 10.66.52.76 with SMTP id r12mr19376171pao.217.1365235981201; Sat, 06 Apr 2013 01:13:01 -0700 (PDT) Original-Received: from debian.emacs ([61.149.228.20]) by mx.google.com with ESMTPS id fb7sm3928726pab.16.2013.04.06.01.12.58 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 06 Apr 2013 01:13:00 -0700 (PDT) X-Mailer: Sylpheed 3.3.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 209.85.160.43 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158709 Archived-At: In admin/notes/commits: Each commit should correspond to a single change (whether spread over multiple files or not). Do not mix different changes in the same commit (eg adding a feature in one file, fixing a bug in another should be two commits, not one). Can I mix changes in _one_ file? (E.g., adding a feature in one file, fixing a bug in the same file) When I want to add a feature in a file, I often find bugs in the same file. It is convenient and natural to fix them without extra trouble, I think. -- Xue Fuqiao http://www.gnu.org/software/emacs/