From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: Recent read-face patch breaks `M-x customize-face' Date: Fri, 5 Apr 2013 19:52:05 +0200 Message-ID: <20130405175202.GB29138@saturn> References: <20130405175032.GA29138@saturn> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: ger.gmane.org 1365278701 30514 80.91.229.3 (6 Apr 2013 20:05:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Apr 2013 20:05:01 +0000 (UTC) Cc: Roland Winkler To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 22:05:00 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOZJS-0001Uu-JK for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 22:02:10 +0200 Original-Received: from localhost ([::1]:54204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOAoK-0005iG-6H for ged-emacs-devel@m.gmane.org; Fri, 05 Apr 2013 13:52:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:39719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOAoB-0005TM-5v for emacs-devel@gnu.org; Fri, 05 Apr 2013 13:52:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOAo8-00010O-BS for emacs-devel@gnu.org; Fri, 05 Apr 2013 13:52:15 -0400 Original-Received: from mail-ea0-x22a.google.com ([2a00:1450:4013:c01::22a]:65226) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOAo8-000106-53; Fri, 05 Apr 2013 13:52:12 -0400 Original-Received: by mail-ea0-f170.google.com with SMTP id a15so1432497eae.1 for ; Fri, 05 Apr 2013 10:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to; bh=XtkTVZx+Kztfq6VcGUTixDAIabqtKkEShsCjqYzPm4E=; b=rohjycOx0o17hk7WoE5+LLm8m1/Box97RXfX3xeEPEm145hgaMceC8t+SIf3RWw6GG 1cYG0i/DOpRDgKTx7GVE+OgeNN9VgQRu4GbnY3qMMSfULAwS8686une3CvdMRvbhIfKu +sa7chjfxSwDWq5bIESj2W6BzVWrjjotYr3l0WwYKwPrTdvvXBqg7zgvPIbCkjeRDhJ+ TnTscAzc+ZIEWP9l9NsJyxEmFWxE9Wj0OGkbrm65dL0KYxFQ5qzmjXw7/ecYBXBLYOG7 +7FezJZZdvlQbasNKSOTWAgByKp/Axnb6QnxfQQwA+iGEIH1LqqPAKGN/nf4M0ARLI4/ h3pA== X-Received: by 10.14.175.71 with SMTP id y47mr21485098eel.18.1365184330863; Fri, 05 Apr 2013 10:52:10 -0700 (PDT) Original-Received: from saturn (217-162-217-29.dynamic.hispeed.ch. [217.162.217.29]) by mx.google.com with ESMTPS id a1sm16763733eep.2.2013.04.05.10.52.08 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 05 Apr 2013 10:52:09 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130405175032.GA29138@saturn> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158729 Archived-At: On 2013-04-05 19:50, Giorgos Keramidas wrote: > commit 605625d262e5e4bf996691027c755c65061492b1 > Author: Roland Winkler > Date: Wed Apr 3 21:12:25 2013 -0500 > > lisp/faces.el (read-face-name): Behave as promised by the docstring. > > | diff --git a/lisp/ChangeLog b/lisp/ChangeLog > | index 2b86faf..7ee201a 100644 > | --- a/lisp/ChangeLog > | +++ b/lisp/ChangeLog > | @@ -1,3 +1,9 @@ > | +2013-04-04 Roland Winkler > | + > | + * faces.el (read-face-name): Behave as promised by the docstring. > | + Assume that arg default is a list of faces. > | + (describe-face): Call read-face-name with list of default faces. > | + > | 2013-04-04 Thierry Volpiatto > | > | * bookmark.el: Fix deletion of bookmarks (bug#13972). > > Does customize-face depend on some bogus assumption that this commit > has now rendered broken?? Verified. Simply reverting lisp/faces.el to its state before this patch, unbreaks `M-x customize-face'.