From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Recent read-face patch breaks `M-x customize-face' Date: Fri, 5 Apr 2013 19:50:34 +0200 Message-ID: <20130405175032.GA29138@saturn> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Trace: ger.gmane.org 1365278624 29487 80.91.229.3 (6 Apr 2013 20:03:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Apr 2013 20:03:44 +0000 (UTC) Cc: Roland Winkler To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 06 22:03:43 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UOZJT-0001KY-4D for ged-emacs-devel@m.gmane.org; Sat, 06 Apr 2013 22:02:11 +0200 Original-Received: from localhost ([::1]:49657 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOAmw-0002sN-PX for ged-emacs-devel@m.gmane.org; Fri, 05 Apr 2013 13:50:59 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:38973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOAmo-0002mI-0K for emacs-devel@gnu.org; Fri, 05 Apr 2013 13:50:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOAmf-0000Nn-TJ for emacs-devel@gnu.org; Fri, 05 Apr 2013 13:50:49 -0400 Original-Received: from mail-ee0-f51.google.com ([74.125.83.51]:43199) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOAmf-0000NS-NC; Fri, 05 Apr 2013 13:50:41 -0400 Original-Received: by mail-ee0-f51.google.com with SMTP id c4so1467039eek.10 for ; Fri, 05 Apr 2013 10:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:mime-version :content-type:content-disposition; bh=hOttNrBCaS6u7doTKejQMhNALBqyOfk+Un99/UtP9WY=; b=BK/lbyC8X/KhjY9H7usKlVZyOvfyUXKaDY1Nesr270Nr8prg76Mq2NFJGvWUUD1BbZ njJXMbwGfGnIKm4lfgiGUIJGuptsCAQzt1+RKZZg8UP5XJ1b9Xnmm+K9VAfV34Xg4BmR imZGiSVZBgskLuwNsWG77UIKu9sHTzqGNcJjICNvJs3GyAV0SZv55sP48g7YiYptJ5ON lIrCeTC3aE2W3DoPnvUJ8ANgRfMyAfFiVjS1lkwnWs1EGw1dJj67NNmUH5eIE/xQB1Km HBhpJtpaAWQiTxVWubE4otEEBekwx1M3ymKZqTBGEBKnTF4uk4JnG8FVPtDt8AltYLnt d0Sg== X-Received: by 10.14.223.69 with SMTP id u45mr21499388eep.23.1365184240209; Fri, 05 Apr 2013 10:50:40 -0700 (PDT) Original-Received: from saturn (217-162-217-29.dynamic.hispeed.ch. [217.162.217.29]) by mx.google.com with ESMTPS id d47sm16717389eem.9.2013.04.05.10.50.38 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 05 Apr 2013 10:50:38 -0700 (PDT) Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 74.125.83.51 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158714 Archived-At: Hi all, I noticed that `M-x customize-face' triggers an error in a recent build of Emacs trunk, and managed to track this backtrace: Debugger entered--Lisp error: (wrong-type-argument sequencep 97) mapconcat((lambda (f) (if (symbolp f) (symbol-name f) f)) "all faces" ", ") (setq default (mapconcat (function (lambda (f) (if (symbolp f) (symbol-name f) f))) default ", ")) (if default (setq default (mapconcat (function (lambda (f) (if (symbolp f) (symbol-name f) f))) defau$ read-face-name("Customize face" "all faces" t) (list (read-face-name "Customize face" "all faces" t)) call-interactively(customize-face record nil) command-execute(customize-face record) execute-extended-command(nil "customize-face") call-interactively(execute-extended-command nil nil) command-execute(execute-extended-command) To the changes of this commit: commit 605625d262e5e4bf996691027c755c65061492b1 Author: Roland Winkler Date: Wed Apr 3 21:12:25 2013 -0500 lisp/faces.el (read-face-name): Behave as promised by the docstring. | diff --git a/lisp/ChangeLog b/lisp/ChangeLog | index 2b86faf..7ee201a 100644 | --- a/lisp/ChangeLog | +++ b/lisp/ChangeLog | @@ -1,3 +1,9 @@ | +2013-04-04 Roland Winkler | + | + * faces.el (read-face-name): Behave as promised by the docstring. | + Assume that arg default is a list of faces. | + (describe-face): Call read-face-name with list of default faces. | + | 2013-04-04 Thierry Volpiatto | | * bookmark.el: Fix deletion of bookmarks (bug#13972). Does customize-face depend on some bogus assumption that this commit has now rendered broken??