From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Alan Mackenzie Newsgroups: gmane.emacs.devel Subject: Re: [RFC] refactoring DEFUN Date: Mon, 25 Mar 2013 13:54:05 +0000 Message-ID: <20130325135405.GA2423@acm.acm> References: <51503B6D.1060203@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1364219680 10591 80.91.229.3 (25 Mar 2013 13:54:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 25 Mar 2013 13:54:40 +0000 (UTC) Cc: Emacs development discussions To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 25 14:55:07 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UK7rd-000445-Iv for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2013 14:55:05 +0100 Original-Received: from localhost ([::1]:32987 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK7rF-0001Er-Qv for ged-emacs-devel@m.gmane.org; Mon, 25 Mar 2013 09:54:41 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK7rC-0001Ek-6b for emacs-devel@gnu.org; Mon, 25 Mar 2013 09:54:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UK7r7-00017q-IU for emacs-devel@gnu.org; Mon, 25 Mar 2013 09:54:38 -0400 Original-Received: from colin.muc.de ([193.149.48.1]:27792 helo=mail.muc.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK7r7-00017a-8i for emacs-devel@gnu.org; Mon, 25 Mar 2013 09:54:33 -0400 Original-Received: (qmail 35975 invoked by uid 3782); 25 Mar 2013 13:54:30 -0000 Original-Received: from acm.muc.de (pD951A467.dip.t-dialin.net [217.81.164.103]) by colin.muc.de (tmda-ofmipd) with ESMTP; Mon, 25 Mar 2013 14:54:27 +0100 Original-Received: (qmail 6061 invoked by uid 1000); 25 Mar 2013 13:54:05 -0000 Content-Disposition: inline In-Reply-To: <51503B6D.1060203@yandex.ru> User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.12 (Macallan) X-Primary-Address: acm@muc.de X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x X-Received-From: 193.149.48.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:158131 Archived-At: Hello Dmitry. On Mon, Mar 25, 2013 at 03:56:29PM +0400, Dmitry Antipov wrote: > Although C preprocessor can't transform the text too much, it's > still possible to use concatenation to avoid silly typing like: > DEFUN ("foo", Ffoo, Sfoo, ...) > and use: > DEFUN ("foo", foo, ...) > instead. The core change is simple, but the obvious rest is ~450K > uncompressed (99.9% was generated by elisp program, BTW). I'm against this change. We don't seem to need it. I think it will cause more work than it will save, given how seldomly we write new DEFUNs. I think it is best to keep Ffoo (at least) explicit. It would be strange indeed if grep finds uses of a DEFUN, but not the DEFUN itself. This would be suboptimal. This explicit Ffoo is used by (amongst others?) c-defun-name, a component of `add-change-log-entry-other-window', C-x 4 a, which is used frequently. After this change, c-defun-name would need to be significantly complicated in order to parse both the traditional and new versions of DEFUN. I am against this change. > Dmitry -- Alan Mackenzie (Nuremberg, Germany).