unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Alan Mackenzie <acm@muc.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, aidalgol@no8wireless.co.nz,
	Tassilo Horn <tsdh@gnu.org>
Subject: Re: Fontless Info
Date: Tue, 19 Feb 2013 23:10:46 +0000	[thread overview]
Message-ID: <20130219231046.GB4377@acm.acm> (raw)
In-Reply-To: <83r4kcp95y.fsf@gnu.org>

Hi, Eli.

On Tue, Feb 19, 2013 at 06:20:41PM +0200, Eli Zaretskii wrote:
> > From: Tassilo Horn <tsdh@gnu.org>
> > Date: Tue, 19 Feb 2013 11:16:25 +0100
> > Cc: emacs-devel@gnu.org

> > Aidan Gauland <aidalgol@no8wireless.co.nz> writes:

> > > Emacs was run with -Q, and I ran `make distclean' before rebuilding
> > > again to make sure it wasn't a problem with my local build.  This
> > > appears to be a bug, but if no one else can reproduce it...

> > You are not alone.  I've just updated my emacs copy, and I can reproduce
> > the issue.  So it's clearly a bug.

> This happens because font-lock-mode gets turned off in Info buffers.
> Type "M-x font-lock-mode RET", and all the niceties are back.  (You
> could guess that this is the problem if you'd go to the un-decorated
> text and type "M-x describe-text-properties RET" there.)

> The reason seems to be the changes in revision 111794: their result is
> that, after Info mode is turned on and turns on font-lock, font-lock
> is turned off again by something called
> global-font-lock-mode-check-buffers.  And to make things _really_
> interesting, if you run this under Edebug, the problem disappears...

Thanks for the prod!

> Since the voodoo of easy-mmode is beyond me, I'll let others fix this.

This might well do the trick:



=== modified file 'lisp/emacs-lisp/easy-mmode.el'
*** lisp/emacs-lisp/easy-mmode.el	2013-02-15 20:01:51 +0000
--- lisp/emacs-lisp/easy-mmode.el	2013-02-19 23:03:30 +0000
***************
*** 417,423 ****
  	 ;; Go through existing buffers.
  	 (dolist (buf (buffer-list))
  	   (with-current-buffer buf
! 	     (if ,global-mode (,turn-on) (when ,mode (,mode -1))))))
  
         ;; Autoloading define-globalized-minor-mode autoloads everything
         ;; up-to-here.
--- 417,425 ----
  	 ;; Go through existing buffers.
  	 (dolist (buf (buffer-list))
  	   (with-current-buffer buf
! 	     (if ,global-mode
! 		 (,turn-on)
! 	       (when ,mode (let (,disable-MODE) (,mode -1)))))))
  
         ;; Autoloading define-globalized-minor-mode autoloads everything
         ;; up-to-here.
***************
*** 439,445 ****
  		   (if ,mode (,mode -1))
  		 (unless (eq ,MODE-major-mode major-mode)
  		   (if ,mode
! 		       (progn
  			 (,mode -1)
  			 (,turn-on))
  		     (,turn-on))))
--- 441,447 ----
  		   (if ,mode (,mode -1))
  		 (unless (eq ,MODE-major-mode major-mode)
  		   (if ,mode
! 		       (let (,disable-MODE)
  			 (,mode -1)
  			 (,turn-on))
  		     (,turn-on))))


-- 
Alan Mackenzie (Nuremberg, Germany).



  parent reply	other threads:[~2013-02-19 23:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19  8:01 Fontless Info Aidan Gauland
2013-02-19 10:16 ` Tassilo Horn
2013-02-19 15:00   ` Drew Adams
2013-02-19 16:33     ` Eli Zaretskii
2013-02-19 16:20   ` Eli Zaretskii
2013-02-19 17:58     ` Drew Adams
2013-02-19 18:48       ` Drew Adams
2013-02-19 20:53         ` Eli Zaretskii
2013-02-19 21:05           ` Drew Adams
2013-02-19 21:21             ` Eli Zaretskii
2013-02-19 21:25               ` Drew Adams
2013-02-20 11:08             ` Michael Heerdegen
2013-02-19 21:14           ` Drew Adams
2013-02-19 23:23       ` Alan Mackenzie
2013-02-20  4:02         ` Drew Adams
2013-02-19 23:10     ` Alan Mackenzie [this message]
2013-02-20 10:58       ` Alan Mackenzie
2013-02-23  4:58       ` Dmitry Gutov
2013-02-24 18:08         ` Alan Mackenzie
2013-02-26  5:43           ` Dmitry Gutov
2013-02-19 16:58 ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130219231046.GB4377@acm.acm \
    --to=acm@muc.de \
    --cc=aidalgol@no8wireless.co.nz \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).