From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Toby Cubitt Newsgroups: gmane.emacs.devel Subject: Re: Allow value of PRINT_CIRCLE to be modified from Elisp? Date: Tue, 2 Oct 2012 12:19:50 +0200 Message-ID: <20121002101950.GA25018@c3po> References: <20120421114423.GA611@c3po.home> Reply-To: Toby Cubitt NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1349173202 27613 80.91.229.3 (2 Oct 2012 10:20:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 2 Oct 2012 10:20:02 +0000 (UTC) Cc: Donald Curtis To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 02 12:20:07 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TIza2-0002qT-0R for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2012 12:19:58 +0200 Original-Received: from localhost ([::1]:57539 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIzZw-0007k2-Dh for ged-emacs-devel@m.gmane.org; Tue, 02 Oct 2012 06:19:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42962) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIzZp-0007ju-Lh for emacs-devel@gnu.org; Tue, 02 Oct 2012 06:19:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TIzZj-0006w3-LV for emacs-devel@gnu.org; Tue, 02 Oct 2012 06:19:45 -0400 Original-Received: from starfish.geekisp.com ([216.168.135.166]:24120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TIzZj-0006vk-G9 for emacs-devel@gnu.org; Tue, 02 Oct 2012 06:19:39 -0400 Original-Received: (qmail 5538 invoked by uid 1003); 2 Oct 2012 10:19:37 -0000 Original-Received: from localhost (localhost.geekisp.com [127.0.0.1]) by localhost.geekisp.com (tmda-ofmipd) with ESMTP; Tue, 02 Oct 2012 06:19:34 -0400 Content-Disposition: inline In-Reply-To: <20120421114423.GA611@c3po.home> X-PGP-Key: http://www.dr-qubit.org/gpg-toby.asc User-Agent: Mutt/1.5.21 (2010-09-15) X-Delivery-Agent: TMDA/1.1.11 (Ladyburn) X-Primary-Address: toby@dr-qubit.org X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 216.168.135.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153895 Archived-At: On Sat, Apr 21, 2012 at 01:44:23PM +0200, Toby Cubitt wrote: > On Fri, Apr 20, 2012 at 09:03:14AM -0400, Stefan Monnier wrote: > > >> Maybe we should simply ignore PRINT_CIRCLE when `print-circle' is > > >> non-nil. > > > > > > That would definitely solve all my problems if it can be done. > > > > Done in the trunk, > > Thanks! I've been testing persistent undo-tree history since this change > was applied, and it seems to be working fine now. It seems this fix didn't make it into the emacs-24 branch. Any reason? Here's the commit: ------------------------------------------------------------ revno: 107975 committer: Stefan Monnier branch nick: trunk timestamp: Fri 2012-04-20 09:02:20 -0400 message: * src/print.c (print_preprocess): Only check print_depth if print-circle is nil. (print_object): Check for cycles even when print-circle is nil and print-gensym is t, but only check print_depth if print-circle is nil. ------------------------------------------------------------ Toby -- Dr T. S. Cubitt Mathematics and Quantum Information group Department of Mathematics Complutense University Madrid, Spain email: tsc25@cantab.net web: www.dr-qubit.org