From: Toby Cubitt <tsc25@cantab.net>
To: emacs-devel@gnu.org
Cc: Donald Curtis <dcurtis@milkbox.net>
Subject: Re: Allow value of PRINT_CIRCLE to be modified from Elisp?
Date: Tue, 2 Oct 2012 12:19:50 +0200 [thread overview]
Message-ID: <20121002101950.GA25018@c3po> (raw)
In-Reply-To: <20120421114423.GA611@c3po.home>
On Sat, Apr 21, 2012 at 01:44:23PM +0200, Toby Cubitt wrote:
> On Fri, Apr 20, 2012 at 09:03:14AM -0400, Stefan Monnier wrote:
> > >> Maybe we should simply ignore PRINT_CIRCLE when `print-circle' is
> > >> non-nil.
> > >
> > > That would definitely solve all my problems if it can be done.
> >
> > Done in the trunk,
>
> Thanks! I've been testing persistent undo-tree history since this change
> was applied, and it seems to be working fine now.
It seems this fix didn't make it into the emacs-24 branch. Any reason?
Here's the commit:
------------------------------------------------------------
revno: 107975
committer: Stefan Monnier <monnier@iro.umontreal.ca>
branch nick: trunk
timestamp: Fri 2012-04-20 09:02:20 -0400
message:
* src/print.c (print_preprocess): Only check print_depth if print-circle
is nil.
(print_object): Check for cycles even when print-circle is nil and
print-gensym is t, but only check print_depth if print-circle is nil.
------------------------------------------------------------
Toby
--
Dr T. S. Cubitt
Mathematics and Quantum Information group
Department of Mathematics
Complutense University
Madrid, Spain
email: tsc25@cantab.net
web: www.dr-qubit.org
next prev parent reply other threads:[~2012-10-02 10:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-19 13:09 Allow value of PRINT_CIRCLE to be modified from Elisp? Toby Cubitt
2012-04-19 22:12 ` Stefan Monnier
2012-04-19 22:25 ` Toby Cubitt
2012-04-20 13:03 ` Stefan Monnier
2012-04-21 11:44 ` Toby Cubitt
2012-10-02 10:19 ` Toby Cubitt [this message]
2012-10-02 13:23 ` Stefan Monnier
2012-10-02 14:04 ` Toby Cubitt
2012-10-02 14:07 ` Donald Ephraim Curtis
2012-10-02 15:00 ` Stefan Monnier
2012-04-20 7:23 ` Andreas Schwab
2012-04-20 11:36 ` Stefan Monnier
2012-04-20 12:06 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121002101950.GA25018@c3po \
--to=tsc25@cantab.net \
--cc=dcurtis@milkbox.net \
--cc=emacs-devel@gnu.org \
--cc=toby-dated-1350382777.be1711@dr-qubit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).