unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Agustin Martin <agustin.martin@hispalinux.es>
To: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r108407: textmodex/{ispell, flyspell}.el: Decrease XEmacs incompatibilities.
Date: Wed, 30 May 2012 17:20:06 +0200	[thread overview]
Message-ID: <20120530152006.GA16796@agmartin.aq.upm.es> (raw)
In-Reply-To: <CAAeL0SQxNqywXxV=RkH_Uc7Hpn-e3VzeDsS3Cpf+q_nbCZU16g@mail.gmail.com>

On Wed, May 30, 2012 at 04:33:07PM +0200, Juanma Barranquero wrote:
> On Mon, May 28, 2012 at 6:11 PM, Agustin Martin
> <agustin.martin@hispalinux.es> wrote:
> > ------------------------------------------------------------
> > revno: 108407
> > committer: Agustin Martin <agustin.martin@hispalinux.es>
> > branch nick: trunk
> > timestamp: Mon 2012-05-28 18:11:15 +0200
> > message:
> >  textmodex/{ispell,flyspell}.el: Decrease XEmacs incompatibilities.
> 
> >  * ispell.el:
> >    (ispell-with-no-warnings): XEmacs alternative `with-no-warnings'
> >    definition or Emacs alias.
> 
> That does not avoid warnings on Emacs, likely because with-no-warnings
> is dealt specially by the bytecompiler.
> 
>   In ispell-message:
>   ispell.el:3733:49:Warning: reference to free variable
>       `sc-reference-tag-string'
>   ispell.el:3738:48:Warning: reference to free variable
>       `message-cite-prefix-regexp'
>   ispell.el:3744:49:Warning: reference to free variable `mh-ins-buf-prefix'
> 
>   In end of data:
>   ispell.el:4048:1:Warning: the function `sc-cite-regexp' is not known to be
>       defined.

Thanks for the info, did not notice that I byte compiled with
byte-compile-warnings nil. Now I see even another couple of obsolete
interactive-p uses. 

Macro definition taken from orgmode seems to do a better job

(defmacro ispell-with-no-warnings (&rest body)
  (cons (if (fboundp 'with-no-warnings) 'with-no-warnings 'progn) body))

-- 
Agustin



      reply	other threads:[~2012-05-30 15:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1SZ2dG-0001ug-Rp@vcs.savannah.gnu.org>
2012-05-30 14:33 ` [Emacs-diffs] /srv/bzr/emacs/trunk r108407: textmodex/{ispell, flyspell}.el: Decrease XEmacs incompatibilities Juanma Barranquero
2012-05-30 15:20   ` Agustin Martin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120530152006.GA16796@agmartin.aq.upm.es \
    --to=agustin.martin@hispalinux.es \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).